Incorrect use_self warning

[MasonRemaley]

I believe I've come across a case where clippy gives a use_self warning but shouldn't:

#![warn(use_self)]

pub trait Foo {
    fn foo() -> Option<()>;
}

impl Foo for Option<i32> {
    fn foo() -> Option<()> { // can't use `Self` here as `Self` is `Option<i32>` not `Option<()>`
        unimplemented!()
    }
}

fn main() {}

(playground link)

It's possible this is actually correct and it just wants me to specify Self with different params in which case I'm just not sure what the syntax is for that.

---

Potentially related, I'd actually be interested in helping out with Clippy. If this seems like an easy issue to get started on I'd be happy to try to fix it myself!

[oli-obk]

Potentially related, I'd actually be interested in helping out with Clippy. If this seems like an easy issue to get started on I'd be happy to try to fix it myself!

Awesome. Currently we bail out if the type has any lifetimes. That means we don't lint some cases that should be linted. To fix this once and for all you'd need to remove the current lifetime check on the impl, and instead check whether the found path does not only match by name, but also by the lifetime and generics.

[MasonRemaley]

Cool okay, sounds straightforward enough--I'll get started on this tomorrow.

[otavio]

I was looking at the use_self and tested your playground link and it seems this issue does not happen anymore. I think it can be closed.

[ghost]

Yes, it's fixed. Updated playground