Access violation exception with nightly-msvc (x86 only)

[pravic]

Funny thing: it works in debug build, but crashes in the release one.

It looks like the failing code is in EarlyLintPass::check_block (according to windows debugger).

https://github.com/rust-lang-nursery/rust-clippy/blob/1ecce2d803dbae76b2956012c3213ce7448cceae/clippy_lints/src/returns.rs#L106-L128

Project which causes this crash: https://github.com/sciter-sdk/rust-sciter (run cargo +nightly clippy).

Env:

rustc 1.25.0-nightly (29c8276 2018-02-07), host: i686-pc-windows-msvc
clippy v0.0.186

[pravic]

It does not crash with x64 compiler, but does with the x86 one. How is it possible?

[pravic]

@oli-obk could you add a bug label here?

[oli-obk]

Thanks for looking into this more closely.

So a debug clippy works but a release clippy fails? Or is it whether the crate is built in release mode?

[pravic]

Yes, it was about the clippy compiled in debug mode.

Only release and only x86 version crashes.

[mati865]

It looks like #3345 which should be fixed with current nightly.
@pravic could you retry?

[pravic]

It was even worse:

$ cargo +stable-i686 clippy
Downloaded lazy_static v1.1.0
Downloaded libc v0.2.43
Compiling version_check v0.1.5
Checking libc v0.2.43
Compiling lazy_static v1.1.0
error: Could not compile libc.
warning: build failed, waiting for other jobs to finish...
error: Could not compile lazy_static.

rustc 1.31.0 (abe02cefd 2018-12-04)
clippy 0.0.212 (2e26fdc 2018-11-22)

But yes, nightly-i686 clippy works well:

rustc 1.33.0-nightly (adbfec2 2018-12-17)
clippy 0.0.212 (a416c5e 2018-12-14)

[pravic]

Huh, how come that it is the same clippy version (0.0.212) in release and nightly with different revisions?
Looks like nobody's bothered to bump it since July: https://github.com/rust-lang/rust-clippy/releases

[mati865]

Clippy is no longer distributed as the crate and versions doesn't matter for rustup.