Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming clippy breakage #2725

Closed
phansch opened this issue May 4, 2018 · 0 comments
Closed

Incoming clippy breakage #2725

phansch opened this issue May 4, 2018 · 0 comments
Labels
good-first-issue These issues are a good way to get started with Clippy I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️

Comments

@phansch
Copy link
Member

phansch commented May 4, 2018

Once rust-lang/rust#50418 is done, we will have to update clippy: rust-lang/rust#50418 (comment)

All the methods of the Delegate trait will take cmt by reference instead and we have to update the places where we use those methods:

https://github.com/rust-lang-nursery/rust-clippy/blob/f84cc2cc3642d54c69e6a2e7748f9468ade0346f/clippy_lints/src/loops.rs#L1414-L1446

https://github.com/rust-lang-nursery/rust-clippy/blob/c1b39c4551cf5645706d1ddd2925d17271638333/clippy_lints/src/needless_pass_by_value.rs#L369-L395

@phansch phansch added good-first-issue These issues are a good way to get started with Clippy I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️ labels May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue These issues are a good way to get started with Clippy I-ICE Issue: Clippy panicked, giving an Internal Compilation Error (ICE) ❄️
Projects
None yet
Development

No branches or pull requests

1 participant