Clippy fails with latest master rustc

[phansch]

Caused by this rollup: rust-lang/rust#56557
Not sure which PR exactly.

[matthiaskrgr]

Probably rust-lang/rust@08f8fae
I'll have a look...

[matthiaskrgr]

Hmm I got it to build via

diff --git a/clippy_lints/src/use_self.rs b/clippy_lints/src/use_self.rs
index 3a71a6d0..27ca01b8 100644
--- a/clippy_lints/src/use_self.rs
+++ b/clippy_lints/src/use_self.rs
@@ -14,7 +14,7 @@ use crate::rustc::ty;
 use crate::rustc::{declare_tool_lint, lint_array};
 use crate::rustc_errors::Applicability;
 use crate::syntax::ast::NodeId;
-use crate::syntax_pos::symbol::keywords::SelfType;
+use crate::syntax_pos::symbol::keywords::SelfUpper;
 use crate::utils::{in_macro, span_lint_and_sugg};
 use if_chain::if_chain;

@@ -226,7 +226,7 @@ struct UseSelfVisitor<'a, 'tcx: 'a> {

 impl<'a, 'tcx> Visitor<'tcx> for UseSelfVisitor<'a, 'tcx> {
     fn visit_path(&mut self, path: &'tcx Path, _id: HirId) {
-        if self.item_path.def == path.def && path.segments.last().expect(SEGMENTS_MSG).ident.name != SelfType.name() {
+        if self.item_path.def == path.def && path.segments.last().expect(SEGMENTS_MSG).ident.name != SelfUpper.name() {
             span_use_self_lint(self.cx, path);
         }

diff --git a/clippy_lints/src/utils/mod.rs b/clippy_lints/src/utils/mod.rs
index 0c6935d8..f1c1b7b5 100644
--- a/clippy_lints/src/utils/mod.rs
+++ b/clippy_lints/src/utils/mod.rs
@@ -970,7 +970,7 @@ pub fn opt_def_id(def: Def) -> Option<DefId> {

 pub fn is_self(slf: &Arg) -> bool {
     if let PatKind::Binding(_, _, name, _) = slf.pat.node {
-        name.name == keywords::SelfValue.name()
+        name.name == keywords::SelfUpper.name()
     } else {
         false
     }

but there are actual test failures now ... :/

[mati865]

@matthiaskrgr

-        name.name == keywords::SelfValue.name()
+        name.name == keywords::SelfUpper.name()

Shouldn't it be:

-        name.name == keywords::SelfValue.name()
+        name.name == keywords::SelfLower.name()

?

[matthiaskrgr]

RIght, thanks, I just found out by trial error :P
Will prep PR in a couple of minutes.