Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint against #[cfg(linux)] → #[cfg(unix)] #3949

Closed
oberien opened this issue Apr 13, 2019 · 2 comments · Fixed by #5506
Closed

Lint against #[cfg(linux)] → #[cfg(unix)] #3949

oberien opened this issue Apr 13, 2019 · 2 comments · Fixed by #5506
Labels
A-lint Area: New lints L-correctness Lint: Belongs in the correctness lint group

Comments

@oberien
Copy link

oberien commented Apr 13, 2019

There have been several instances where I wrote #[cfg(linux)] to feature-gate something to linux. This is wrong and will never be evaluated to true. Instead #[cfg(unix)] must be used.
@flip1995 flip1995 added L-correctness Lint: Belongs in the correctness lint group A-lint Area: New lints labels Apr 13, 2019
@JamesHinshelwood
Copy link
Contributor

Another possibility could be that #[cfg(target_os="linux")] was intended. I guess we could suggest both?

@euclio
Copy link
Contributor

euclio commented Jan 17, 2020 •
edited
Loading

I also think it would be useful to lint #[cfg(macos)] -> #[cfg(target_os="macos")].

@ebroto ebroto mentioned this issue Apr 22, 2020
Merged
@bors bors closed this as completed in 5d8a3e8 Apr 27, 2020
@youjiali1995 youjiali1995 mentioned this issue Jul 2, 2020
Merged
@est31 est31 mentioned this issue May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints L-correctness Lint: Belongs in the correctness lint group
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement mismatched_target_os lint ebroto/rust-clippy
4 participants
@euclio @oberien @flip1995 @JamesHinshelwood