Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clippy-driver --wrapper #4172

Closed
Manishearth opened this issue Jun 4, 2019 · 2 comments
Closed

Support clippy-driver --wrapper #4172

Manishearth opened this issue Jun 4, 2019 · 2 comments

Comments

@Manishearth
Copy link
Member

Currently clippy-driver is a RUSTC_WRAPPER, i.e. it takes the name of the rustc executable as its first parameter.

What we should do is make it so that clippy-driver --wrapper is the RUSTC_WRAPPER, and then migrate cargo-clippy over to this. This opens up using the clippy-driver as a direct rustc drop-in in cargo clippy-preview.

This intermediate step is necessary so that cargo-clippy continues to work while we hack on cargo clippy-preview

cc @yaahallo

@Manishearth
Copy link
Member Author

Oh, this is also really three steps:

  • First we should add --wrapper and make cargo-clippy and cargo clippy-preview use it.
  • Then, we should make non---wrapper calls not consume the rustc argument
  • Then, we should make cargo clippy-preview stop using --wrapper, and not pass in a rustc. This is basically making cargo clippy replace rustc (for in-workspace crates only)

This last thing is its own task and probably should be a separate issue on Cargo when we get to it. It might be a bit more involved.

@Manishearth
Copy link
Member Author

After some discussion we realized we don't need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant