Lint simplifyable ok_or_else usage

[oli-cosmian]

The following code uses String::from

fn bar() -> Result<i32, String> {
    let x = Some(52.3).ok_or_else(|| String::from("foo"))?;
    Ok(42)
}

but Some(52.3).ok_or("foo")?; would also compile

So if an ok_or_else is followed by a ? and the inner function is calling From::from (or a specific version of it), we should be able to convert it to an ok_or without that call.

[HMPerson1]

@rustbot claim

[7ERr0r]

Sometimes it's the other way.

Performance intensive code:

FromPrimitive::from_u8(mode).ok_or(
    MyReadError::Custom(Box::new(format!("unknown mode: {mode}")))
)

Should not call fmt::format, but instead:

FromPrimitive::from_u8(mode).ok_or_else(|| {
    MyReadError::Custom(Box::new(format!("unknown mode: {mode}")))
})