-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy::missing_safety_doc triggers on macro generated code #4949
Comments
I'm fine with adding a macro check. On the other hand, it might be a good idea to fix this in |
In general, I see a category of lints we disable in external macros, but we might want to let the user enable to help them audit their proc-macro dependencies. |
If someone has a lot of spare time, a lint audit which puts lints in categories like
would be really helpful, since a lot of issues are reports about a lint running in a macro. |
I've started a table with the lints (and have looked up the first 50 or so), hopefully I'll find the time to finish it during the holidays. |
See rust-embedded/cortex-m-rt#225, the
#[interrupt]
and#[entry]
proc-macros fromcortex-m-rt
generatepub unsafe fn
without safety documentation, which triggers themissing_safety_doc
lint. @jonas-schievink suggests that since these are generated by external macros the lint shouldn't be triggering on them.The text was updated successfully, but these errors were encountered: