Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple_crate_versions lint detects dev dependencies also #5041

Closed
tkaitchuck opened this issue Jan 11, 2020 · 0 comments · Fixed by #5636
Closed

multiple_crate_versions lint detects dev dependencies also #5041

tkaitchuck opened this issue Jan 11, 2020 · 0 comments · Fixed by #5636
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages T-cargo Type: cargo related

Comments

@tkaitchuck
Copy link

The stated reason for the multiple_crate_versions check is

This bloats the size of targets, and can lead to confusing error messages when structs or traits are used interchangeably between different versions of a crate.

However this error triggers when multiple crates declare a dev dependency on the same target also. For example:

warning: multiple versions for dependency `syn`: 0.15.44, 1.0.11
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

However because this is a dev dependency it should not cause any of the issues mentioned above. It would be good to exclude dev and test dependencies from this check.

@JohnTitor JohnTitor added C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages T-cargo Type: cargo related labels Jan 11, 2020
@bors bors closed this as completed in 182ac89 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages T-cargo Type: cargo related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants