Misleading code example for wrong_pub_self_convention lint

[ThibsG]

The wrong_pub_self_convention example from documentation is kind of misleading to me.

The example for this lint is:

# struct X;
impl<'a> X {
    pub fn as_str(self) -> &'a str {
        "foo"
    }
}

On playground, it fires wrong_self_convention (instead wrong_pub_self_convention), so the example or the lint needs to be reworked.

The difference with wrong_self_convention example is mainly the pub keyword on the method as_str, but the lint doesn't use the function visibility as condition to choose which lint to fire (in fact it uses the visibility of the impl item).

As proposed in #6316, it would probably make sense to also look into the history of the lints, what were the reasons to split them (if that was the case)?
It seems there are no tests for the pub variant.

[ThibsG]

@rustbot modify labels: +L-enhancement +L-lint +L-documentation