incorrect clippy lint needless_question_mark

[kgv]

Lint name:
needless_question_mark

I tried this code (link to playground):

pub struct Three {
    two: Option<Two>,
}

impl Three {
    pub fn default(&self) -> Option<&Item> {
        Some(self.two.as_deref()?)
    }
    
    // This is clippy suggestion (not working)
    // pub fn default(&self) -> Option<&Item> {
    //     self.two.as_deref()
    // }
}

pub struct Two {
    one: One,
}

impl Deref for Two {
    type Target = One;

    fn deref(&self) -> &Self::Target {
        &self.one
    }
}

pub struct One {
    item: Item,
}

impl Deref for One {
    type Target = Item;

    fn deref(&self) -> &Self::Target {
        &self.item
    }
}

pub struct Item;

In this case, the question mark is needed.
Clippy suggestion doesn't work.

Meta

• cargo clippy -V:

  clippy 0.1.52 (07e0e2ec 2021-03-24)
  

• rustc -Vv:

  rustc 1.53.0-nightly (07e0e2ec2 2021-03-24)
  binary: rustc
  commit-hash: 07e0e2ec268c140e607e1ac7f49f145612d0f597
  commit-date: 2021-03-24
  host: x86_64-pc-windows-msvc
  release: 1.53.0-nightly
  LLVM version: 12.0.0
  

[camsteffen]

Minimal example

fn foo(s: Option<&String>) -> Option<&str> {
    Some(s?)
}

[ghost]

So this should be the suggestion?

fn foo(s: Option<&String>) -> Option<&str> {
    s.map(|x| &**x)
}

You still want to lint ? in the terminating expression.

This is lint is saying ? is for flow control not for type coercions.

[camsteffen]

I think that suggestion would have to come from a different (new) lint since the question mark is not "needless".