Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error format: all diagnostics are now highlighted as errors #156

Open
birkenfeld opened this issue May 14, 2016 · 3 comments
Open

New error format: all diagnostics are now highlighted as errors #156

birkenfeld opened this issue May 14, 2016 · 3 comments

Comments

@birkenfeld
Copy link
Contributor

With the old error format, rust-mode was able to recognize errors, warnings and other info messages. The result was that compilation-mode could use different faces to distinguish between messages visually (compilation-error, compilation-warning, compilation-info).

This is now gone; all diagnostics are categorized as errors and highlighted as such (or rather, their position is). Since notes/help do no longer have individual file:line, it's not particularly serious, but unfortunate.

@birkenfeld birkenfeld changed the title New error format: all diagnostics are now errors New error format: all diagnostics are now highlighted as errors May 14, 2016
@nikomatsakis
Copy link
Contributor

Ah yes, I meant to address this by changing the new error format generating code.

@qdot
Copy link

qdot commented Aug 11, 2016

+1 on this since the new error format landed in nightly but compilation mode highlighting hasn't been updated yet.

@blaenk
Copy link

blaenk commented Aug 11, 2017

Just wanted to state another reason for fixing this. Emacs commit emacs-mirror/emacs@846870e added automatic support for counting each type of error, so that for example, the count of each can be displayed on the mode-line.

I added this information to my mode-line but indeed all errors regardless of type show up as errors (despite them all being warnings in my case, for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants