Skip to content

Commit

Permalink
Fix regression in resolution of primitive types
Browse files Browse the repository at this point in the history
  • Loading branch information
petrochenkov committed Dec 14, 2016
1 parent b197e4a commit 0157e6c
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/librustc_resolve/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ impl<'a> LexicalScopeBinding<'a> {
}
}

#[derive(Copy, Clone)]
#[derive(Copy, Clone, PartialEq)]
enum PathScope {
Global,
Lexical,
Expand Down Expand Up @@ -2292,7 +2292,9 @@ impl<'a> Resolver<'a> {
//
// Such behavior is required for backward compatibility.
// The same fallback is used when `a` resolves to nothing.
_ if self.primitive_type_table.primitive_types.contains_key(&path[0].name) => {
PathResult::Module(..) | PathResult::Failed(..)
if scope == PathScope::Lexical && (ns == TypeNS || path.len() > 1) &&
self.primitive_type_table.primitive_types.contains_key(&path[0].name) => {
PathResolution {
base_def: Def::PrimTy(self.primitive_type_table.primitive_types[&path[0].name]),
depth: segments.len() - 1,
Expand Down
20 changes: 20 additions & 0 deletions src/test/compile-fail/resolve-primitive-fallback.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {
// Make sure primitive type fallback doesn't work in value namespace
std::mem::size_of(u16);
//~^ ERROR unresolved name `u16`
//~| ERROR this function takes 0 parameters but 1 parameter was supplied

// Make sure primitive type fallback doesn't work with global paths
let _: ::u8;
//~^ ERROR type name `u8` is undefined or not in scope
}

0 comments on commit 0157e6c

Please sign in to comment.