Skip to content

Commit

Permalink
rewrite sanitizer-staticlib-link to rmake
Browse files Browse the repository at this point in the history
  • Loading branch information
Oneirical committed Jul 22, 2024
1 parent aecf0b8 commit 07282e8
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 21 deletions.
1 change: 0 additions & 1 deletion src/tools/tidy/src/allowed_run_make_makefiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ run-make/reproducible-build/Makefile
run-make/rlib-format-packed-bundled-libs-2/Makefile
run-make/rlib-format-packed-bundled-libs-3/Makefile
run-make/rlib-format-packed-bundled-libs/Makefile
run-make/sanitizer-staticlib-link/Makefile
run-make/share-generics-dylib/Makefile
run-make/simd-ffi/Makefile
run-make/split-debuginfo/Makefile
Expand Down
20 changes: 0 additions & 20 deletions tests/run-make/sanitizer-staticlib-link/Makefile

This file was deleted.

26 changes: 26 additions & 0 deletions tests/run-make/sanitizer-staticlib-link/rmake.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// This test first builds a staticlib with AddressSanitizer and checks that
// linking it to an executable fails due to the missing sanitizer runtime.
// It then builds an executable linking to the staticlib and checks that
// the fault in the staticlib is detected correctly.

// Note that checking for the link failure actually checks two things at once:
// 1) That the library has the sanitizer intrumentation
// 2) and that library does not have the sanitizer runtime
// See https://github.com/rust-lang/rust/pull/38699

//@ needs-sanitizer-support
//@ needs-sanitizer-address

use run_make_support::{cc, extra_c_flags, extra_cxx_flags, run_fail, rustc, static_lib_name};

fn main() {
rustc().arg("-g").arg("-Zsanitizer=address").crate_type("staticlib").input("library.rs").run();
cc().input("program.c")
.arg(static_lib_name("library"))
.out_exe("program")
.args(extra_c_flags())
.args(extra_cxx_flags())
.run_fail();
rustc().arg("-g").arg("-Zsanitizer=address").crate_type("bin").input("program.rs").run();
run_fail("program").assert_stderr_contains("stack-buffer-overflow");
}

0 comments on commit 07282e8

Please sign in to comment.