Skip to content

Commit

Permalink
Implement UnwindSafe and RefUnwindSafe for Backtrace
Browse files Browse the repository at this point in the history
Backtrace doesn't have visible mutable state.
  • Loading branch information
KamilaBorowska committed Jul 31, 2023
1 parent 03b8b50 commit 0f06b07
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
3 changes: 2 additions & 1 deletion library/std/src/backtrace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ use crate::backtrace_rs::{self, BytesOrWideString};
use crate::env;
use crate::ffi::c_void;
use crate::fmt;
use crate::panic::UnwindSafe;
use crate::sync::atomic::{AtomicUsize, Ordering::Relaxed};
use crate::sync::LazyLock;
use crate::sys_common::backtrace::{lock, output_filename};
Expand Down Expand Up @@ -427,7 +428,7 @@ impl fmt::Display for Backtrace {
}
}

type LazyResolve = impl (FnOnce() -> Capture) + Send + Sync;
type LazyResolve = impl (FnOnce() -> Capture) + Send + Sync + UnwindSafe;

fn lazy_resolve(mut capture: Capture) -> LazyResolve {
move || {
Expand Down
7 changes: 7 additions & 0 deletions library/std/src/backtrace/tests.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use super::*;
use crate::panic::{RefUnwindSafe, UnwindSafe};

fn generate_fake_frames() -> Vec<BacktraceFrame> {
vec![
Expand Down Expand Up @@ -91,3 +92,9 @@ fn test_frames() {

assert!(iter.all(|(f, e)| format!("{f:#?}") == *e));
}

#[test]
fn backtrace_unwind_safe() {
fn assert_unwind_safe<T: UnwindSafe + RefUnwindSafe>() {}
assert_unwind_safe::<Backtrace>();
}

0 comments on commit 0f06b07

Please sign in to comment.