Skip to content

Commit 12108d2

Browse files
committed
meta: notify #t-rustdoc Zulip stream on backport nominations
1 parent e76cb8c commit 12108d2

File tree

1 file changed

+35
-1
lines changed

1 file changed

+35
-1
lines changed

triagebot.toml

+35-1
Original file line numberDiff line numberDiff line change
@@ -389,13 +389,47 @@ message_on_reopen = "Issue #{number} has been reopened."
389389

390390
[notify-zulip."T-rustdoc"]
391391
required_labels = ["I-nominated"]
392-
zulip_stream = 266220 # #rustdoc
392+
zulip_stream = 266220 # #t-rustdoc
393393
topic = "nominated: #{number}"
394394
message_on_add = """\
395395
@*T-rustdoc* issue #{number} "{title}" has been nominated for `T-rustdoc` discussion.
396396
"""
397397
message_on_remove = "Issue #{number}'s nomination request has been removed."
398398

399+
# FIXME(fmease): Consider adding support for `stable-nominated`, too.
400+
# FIXME(fmease): This is not ideal, we're essentially preventing other teams from
401+
# adding their own custom logic for `beta-nominated`.
402+
# We could swap `beta-nominated` and `T-rustdoc` just like above ("T-rustdoc", "I-nominated").
403+
# https://github.com/rust-lang/rust/pull/82689#discussion_r585159710
404+
# However, that's far from ideal as the removal of "beta-nominated" wouldn't be detected
405+
# IIUC.
406+
# FIXME(fmease): Ideally, we would also send a message or resolve the Zulip topic once `beta-accepted`
407+
# has been added.
408+
[notify-zulip."beta-nominated"]
409+
required_labels = ["T-rustdoc"]
410+
zulip_stream = 266220 # #t-rustdoc
411+
topic = "beta-nominated: #{number}"
412+
# FIXME(fmease): Unfortunately, Zulip polls may not contain any other text
413+
# https://zulip.com/help/create-a-poll#troubleshooting
414+
message_on_add = """\
415+
@*T-rustdoc* PR #{number} "{title}" has been nominated for beta backport.
416+
"""
417+
# FIXME(fmease): ... consider patching `triagebot` to allow posting several messages.
418+
# message_on_add = [
419+
# """\
420+
# @*T-rustdoc* PR #{number} "{title}" has been nominated for beta backport.
421+
# """,
422+
# """\
423+
# /poll Approve beta backport of #{number}?
424+
# approve
425+
# decline
426+
# don't know
427+
# """,
428+
# ]
429+
message_on_remove = "PR #{number}'s beta-nomination has been removed."
430+
message_on_close = "PR #{number} has been closed. Thanks for participating!"
431+
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
432+
399433
[notify-zulip."I-types-nominated"]
400434
zulip_stream = 326866 # #T-types/nominated
401435
topic = "#{number}: {title}"

0 commit comments

Comments
 (0)