Skip to content

Commit 13d59ec

Browse files
committedNov 13, 2024
use --exact on --skip to avoid unintended substring matches
Without the `--exact` flag, using `--skip tests/rustdoc` can unintentionally skip other tests that match as substrings such as `rustdoc-gui`, `rustdoc-js`, etc. For debugging, run: `./x.py --stage 2 test rustdoc-ui --skip tests/rustdoc` and `./x.py --stage 2 test rustdoc-ui --skip tests/rustdoc -- --exact` Signed-off-by: onur-ozkan <work@onurozkan.dev>
1 parent f5b6257 commit 13d59ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/ci/github-actions/jobs.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ runners:
4848

4949
envs:
5050
env-x86_64-apple-tests: &env-x86_64-apple-tests
51-
SCRIPT: ./x.py --stage 2 test --skip tests/ui --skip tests/rustdoc
51+
SCRIPT: ./x.py --stage 2 test --skip tests/ui --skip tests/rustdoc -- --exact
5252
RUST_CONFIGURE_ARGS: --build=x86_64-apple-darwin --enable-sanitizers --enable-profiler --set rust.jemalloc
5353
RUSTC_RETRY_LINKER_ON_SEGFAULT: 1
5454
MACOSX_DEPLOYMENT_TARGET: 10.12

0 commit comments

Comments
 (0)