Always constrain the return type in lifetime suggestion

estebank · estebank · commit 1420bc50b153 · 2024-05-05T03:42:47.000Z
```
error: lifetime may not live long enough
 --&gt; f205.rs:8:16
  |
7 |     fn resolve_symbolic_reference(&amp;self, reference: Option&lt;Reference&gt;) -&gt; Option&lt;Reference&gt; {
  |                                   -      --------- has type `Option&lt;Reference&lt;'1&gt;&gt;`
  |                                   |
  |                                   let's call the lifetime of this reference `'2`
8 |         return reference;
  |                ^^^^^^^^^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
  |
help: consider introducing a named lifetime parameter
  |
7 |     fn resolve_symbolic_reference&lt;'a&gt;(&amp;'a self, reference: Option&lt;Reference&lt;'a&gt;&gt;) -&gt; Option&lt;Reference&lt;'a&gt;&gt; {
  |                                  ++++  ++                                  ++++                      ++++
```

The correct suggestion would be

```
help: consider introducing a named lifetime parameter
  |
7 |     fn resolve_symbolic_reference&lt;'a&gt;(&amp;self, reference: Option&lt;Reference&lt;'a&gt;&gt;) -&gt; Option&lt;Reference&lt;'a&gt;&gt; {
  |                                  ++++                                   ++++                      ++++
```

but we are not doing the analysis to detect that yet. If we constrain `&amp;'a self`, then the return type with a borrow will implicitly take its lifetime from `'a`, it is better to make it explicit in the suggestion, in case that `&amp;self` *doesn't* need to be `'a`, but the return does.
diff --git a/compiler/rustc_infer/src/errors/mod.rs b/compiler/rustc_infer/src/errors/mod.rs
@@ -450,6 +450,11 @@ impl Subdiagnostic for AddLifetimeParamsSuggestion<'_> {
             };
             visitor.visit_ty(self.ty_sub);
             visitor.visit_ty(self.ty_sup);
+            if let Some(fn_decl) = node.fn_decl()
+                && let hir::FnRetTy::Return(ty) = fn_decl.output
+            {
+                visitor.visit_ty(ty);
+            }
             if visitor.suggestions.is_empty() {
                 return false;
             }
diff --git a/tests/ui/lifetimes/issue-17728.stderr b/tests/ui/lifetimes/issue-17728.stderr
@@ -29,8 +29,8 @@ LL |             Some(entry) => Ok(entry),
    |
 help: consider introducing a named lifetime parameter
    |
-LL |     fn attemptTraverse<'a>(&'a self, room: &'a Room, directionStr: &str) -> Result<&Room, &str> {
-   |                       ++++  ++              ++
+LL |     fn attemptTraverse<'a>(&'a self, room: &'a Room, directionStr: &str) -> Result<&'a Room, &'a str> {
+   |                       ++++  ++              ++                                      ++        ++
 
 error: aborting due to 2 previous errors
 
diff --git a/tests/ui/lifetimes/lifetime-errors/ex1-return-one-existing-name-return-type-is-anon.stderr b/tests/ui/lifetimes/lifetime-errors/ex1-return-one-existing-name-return-type-is-anon.stderr
@@ -11,8 +11,8 @@ LL |     x
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |   fn foo<'a>(&'a self, x: &'a i32) -> &i32 {
-   |               ++
+LL |   fn foo<'a>(&'a self, x: &'a i32) -> &'a i32 {
+   |               ++                       ++
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-return-type-is-anon.stderr b/tests/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-return-type-is-anon.stderr
@@ -10,8 +10,8 @@ LL |     x
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |   fn foo<'a>(&'a self, x: &'a i32) -> &i32 {
-   |               ++           ++
+LL |   fn foo<'a>(&'a self, x: &'a i32) -> &'a i32 {
+   |               ++           ++          ++
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-self-is-anon.stderr b/tests/ui/lifetimes/lifetime-errors/ex3-both-anon-regions-self-is-anon.stderr
@@ -10,8 +10,8 @@ LL |         if true { x } else { self }
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn foo<'a>(&'a self, x: &'a Foo) -> &Foo {
-   |                 ++           ++
+LL |     fn foo<'a>(&'a self, x: &'a Foo) -> &'a Foo {
+   |                 ++           ++          ++
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/self/arbitrary_self_types_pin_lifetime_mismatch.stderr b/tests/ui/self/arbitrary_self_types_pin_lifetime_mismatch.stderr
@@ -9,8 +9,8 @@ LL |     fn a(self: Pin<&Foo>, f: &Foo) -> &Foo { f }
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn a<'a>(self: Pin<&'a Foo>, f: &'a Foo) -> &Foo { f }
-   |         ++++            ++           ++
+LL |     fn a<'a>(self: Pin<&'a Foo>, f: &'a Foo) -> &'a Foo { f }
+   |         ++++            ++           ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/arbitrary_self_types_pin_lifetime_mismatch.rs:9:69
@@ -23,8 +23,8 @@ LL |     fn c(self: Pin<&Self>, f: &Foo, g: &Foo) -> (Pin<&Foo>, &Foo) { (self,
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn c<'a>(self: Pin<&'a Self>, f: &'a Foo, g: &Foo) -> (Pin<&Foo>, &Foo) { (self, f) }
-   |         ++++            ++            ++
+LL |     fn c<'a>(self: Pin<&'a Self>, f: &'a Foo, g: &Foo) -> (Pin<&'a Foo>, &'a Foo) { (self, f) }
+   |         ++++            ++            ++                        ++        ++
 
 error: lifetime may not live long enough
   --> $DIR/arbitrary_self_types_pin_lifetime_mismatch.rs:15:58
@@ -36,8 +36,8 @@ LL |     fn bar<'a>(self: Alias<&Self>, arg: &'a ()) -> &() { arg }
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn bar<'a>(self: Alias<&'a Self>, arg: &'a ()) -> &() { arg }
-   |                             ++
+LL |     fn bar<'a>(self: Alias<&'a Self>, arg: &'a ()) -> &'a () { arg }
+   |                             ++                         ++
 
 error: aborting due to 3 previous errors
 
diff --git a/tests/ui/self/elision/lt-ref-self.stderr b/tests/ui/self/elision/lt-ref-self.stderr
@@ -10,8 +10,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn ref_self<'a>(&'a self, f: &'a u32) -> &u32 {
-   |                ++++  ++           ++
+LL |     fn ref_self<'a>(&'a self, f: &'a u32) -> &'a u32 {
+   |                ++++  ++           ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/lt-ref-self.rs:18:9
@@ -25,8 +25,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn ref_Self<'a>(self: &'a Self, f: &'a u32) -> &u32 {
-   |                ++++        ++           ++
+LL |     fn ref_Self<'a>(self: &'a Self, f: &'a u32) -> &'a u32 {
+   |                ++++        ++           ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/lt-ref-self.rs:23:9
@@ -40,8 +40,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_ref_Self<'a>(self: Box<&'a Self>, f: &'a u32) -> &u32 {
-   |                    ++++            ++            ++
+LL |     fn box_ref_Self<'a>(self: Box<&'a Self>, f: &'a u32) -> &'a u32 {
+   |                    ++++            ++            ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/lt-ref-self.rs:28:9
@@ -55,8 +55,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn pin_ref_Self<'a>(self: Pin<&'a Self>, f: &'a u32) -> &u32 {
-   |                    ++++            ++            ++
+LL |     fn pin_ref_Self<'a>(self: Pin<&'a Self>, f: &'a u32) -> &'a u32 {
+   |                    ++++            ++            ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/lt-ref-self.rs:33:9
@@ -70,8 +70,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_box_ref_Self<'a>(self: Box<Box<&'a Self>>, f: &'a u32) -> &u32 {
-   |                        ++++                ++             ++
+LL |     fn box_box_ref_Self<'a>(self: Box<Box<&'a Self>>, f: &'a u32) -> &'a u32 {
+   |                        ++++                ++             ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/lt-ref-self.rs:38:9
@@ -85,8 +85,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_pin_Self<'a>(self: Box<Pin<&'a Self>>, f: &'a u32) -> &u32 {
-   |                    ++++                ++             ++
+LL |     fn box_pin_Self<'a>(self: Box<Pin<&'a Self>>, f: &'a u32) -> &'a u32 {
+   |                    ++++                ++             ++          ++
 
 error: aborting due to 6 previous errors
 
diff --git a/tests/ui/self/elision/ref-mut-self.stderr b/tests/ui/self/elision/ref-mut-self.stderr
@@ -10,8 +10,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn ref_self<'a>(&'a mut self, f: &'a u32) -> &u32 {
-   |                ++++  ++               ++
+LL |     fn ref_self<'a>(&'a mut self, f: &'a u32) -> &'a u32 {
+   |                ++++  ++               ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-self.rs:18:9
@@ -25,8 +25,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn ref_Self<'a>(self: &'a mut Self, f: &'a u32) -> &u32 {
-   |                ++++        ++               ++
+LL |     fn ref_Self<'a>(self: &'a mut Self, f: &'a u32) -> &'a u32 {
+   |                ++++        ++               ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-self.rs:23:9
@@ -40,8 +40,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_ref_Self<'a>(self: Box<&'a mut Self>, f: &'a u32) -> &u32 {
-   |                    ++++            ++                ++
+LL |     fn box_ref_Self<'a>(self: Box<&'a mut Self>, f: &'a u32) -> &'a u32 {
+   |                    ++++            ++                ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-self.rs:28:9
@@ -55,8 +55,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn pin_ref_Self<'a>(self: Pin<&'a mut Self>, f: &'a u32) -> &u32 {
-   |                    ++++            ++                ++
+LL |     fn pin_ref_Self<'a>(self: Pin<&'a mut Self>, f: &'a u32) -> &'a u32 {
+   |                    ++++            ++                ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-self.rs:33:9
@@ -70,8 +70,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_box_ref_Self<'a>(self: Box<Box<&'a mut Self>>, f: &'a u32) -> &u32 {
-   |                        ++++                ++                 ++
+LL |     fn box_box_ref_Self<'a>(self: Box<Box<&'a mut Self>>, f: &'a u32) -> &'a u32 {
+   |                        ++++                ++                 ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-self.rs:38:9
@@ -85,8 +85,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_pin_ref_Self<'a>(self: Box<Pin<&'a mut Self>>, f: &'a u32) -> &u32 {
-   |                        ++++                ++                 ++
+LL |     fn box_pin_ref_Self<'a>(self: Box<Pin<&'a mut Self>>, f: &'a u32) -> &'a u32 {
+   |                        ++++                ++                 ++          ++
 
 error: aborting due to 6 previous errors
 
diff --git a/tests/ui/self/elision/ref-mut-struct.stderr b/tests/ui/self/elision/ref-mut-struct.stderr
@@ -10,8 +10,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn ref_Struct<'a>(self: &'a mut Struct, f: &'a u32) -> &u32 {
-   |                  ++++        ++                 ++
+LL |     fn ref_Struct<'a>(self: &'a mut Struct, f: &'a u32) -> &'a u32 {
+   |                  ++++        ++                 ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-struct.rs:16:9
@@ -25,8 +25,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_ref_Struct<'a>(self: Box<&'a mut Struct>, f: &'a u32) -> &u32 {
-   |                      ++++            ++                  ++
+LL |     fn box_ref_Struct<'a>(self: Box<&'a mut Struct>, f: &'a u32) -> &'a u32 {
+   |                      ++++            ++                  ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-struct.rs:21:9
@@ -40,8 +40,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn pin_ref_Struct<'a>(self: Pin<&'a mut Struct>, f: &'a u32) -> &u32 {
-   |                      ++++            ++                  ++
+LL |     fn pin_ref_Struct<'a>(self: Pin<&'a mut Struct>, f: &'a u32) -> &'a u32 {
+   |                      ++++            ++                  ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-struct.rs:26:9
@@ -55,8 +55,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_box_ref_Struct<'a>(self: Box<Box<&'a mut Struct>>, f: &'a u32) -> &u32 {
-   |                          ++++                ++                   ++
+LL |     fn box_box_ref_Struct<'a>(self: Box<Box<&'a mut Struct>>, f: &'a u32) -> &'a u32 {
+   |                          ++++                ++                   ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-mut-struct.rs:31:9
@@ -70,8 +70,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_pin_ref_Struct<'a>(self: Box<Pin<&'a mut Struct>>, f: &'a u32) -> &u32 {
-   |                          ++++                ++                   ++
+LL |     fn box_pin_ref_Struct<'a>(self: Box<Pin<&'a mut Struct>>, f: &'a u32) -> &'a u32 {
+   |                          ++++                ++                   ++          ++
 
 error: aborting due to 5 previous errors
 
diff --git a/tests/ui/self/elision/ref-self.stderr b/tests/ui/self/elision/ref-self.stderr
@@ -10,8 +10,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn ref_self<'a>(&'a self, f: &'a u32) -> &u32 {
-   |                ++++  ++           ++
+LL |     fn ref_self<'a>(&'a self, f: &'a u32) -> &'a u32 {
+   |                ++++  ++           ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-self.rs:28:9
@@ -25,8 +25,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn ref_Self<'a>(self: &'a Self, f: &'a u32) -> &u32 {
-   |                ++++        ++           ++
+LL |     fn ref_Self<'a>(self: &'a Self, f: &'a u32) -> &'a u32 {
+   |                ++++        ++           ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-self.rs:33:9
@@ -40,8 +40,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_ref_Self<'a>(self: Box<&'a Self>, f: &'a u32) -> &u32 {
-   |                    ++++            ++            ++
+LL |     fn box_ref_Self<'a>(self: Box<&'a Self>, f: &'a u32) -> &'a u32 {
+   |                    ++++            ++            ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-self.rs:38:9
@@ -55,8 +55,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn pin_ref_Self<'a>(self: Pin<&'a Self>, f: &'a u32) -> &u32 {
-   |                    ++++            ++            ++
+LL |     fn pin_ref_Self<'a>(self: Pin<&'a Self>, f: &'a u32) -> &'a u32 {
+   |                    ++++            ++            ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-self.rs:43:9
@@ -70,8 +70,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_box_ref_Self<'a>(self: Box<Box<&'a Self>>, f: &'a u32) -> &u32 {
-   |                        ++++                ++             ++
+LL |     fn box_box_ref_Self<'a>(self: Box<Box<&'a Self>>, f: &'a u32) -> &'a u32 {
+   |                        ++++                ++             ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-self.rs:48:9
@@ -85,8 +85,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn box_pin_ref_Self<'a>(self: Box<Pin<&'a Self>>, f: &'a u32) -> &u32 {
-   |                        ++++                ++             ++
+LL |     fn box_pin_ref_Self<'a>(self: Box<Pin<&'a Self>>, f: &'a u32) -> &'a u32 {
+   |                        ++++                ++             ++          ++
 
 error: lifetime may not live long enough
   --> $DIR/ref-self.rs:53:9
@@ -100,8 +100,8 @@ LL |         f
    |
 help: consider introducing a named lifetime parameter and update trait if needed
    |
-LL |     fn wrap_ref_Self_Self<'a>(self: Wrap<&'a Self, Self>, f: &'a u8) -> &u8 {
-   |                          ++++             ++                  ++
+LL |     fn wrap_ref_Self_Self<'a>(self: Wrap<&'a Self, Self>, f: &'a u8) -> &'a u8 {
+   |                          ++++             ++                  ++         ++
 
 error: aborting due to 7 previous errors
 
diff --git a/tests/ui/self/elision/ref-struct.stderr b/tests/ui/self/elision/ref-struct.stderr

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,8 @@ LL \| Some(entry) => Ok(entry),`
`29`	`29`	`\|`
`30`	`30`	`help: consider introducing a named lifetime parameter`
`31`	`31`	`\|`
`32`		`-LL \| fn attemptTraverse<'a>(&'a self, room: &'a Room, directionStr: &str) -> Result<&Room, &str> {`
`33`		`- \| ++++ ++ ++`
	`32`	`+LL \| fn attemptTraverse<'a>(&'a self, room: &'a Room, directionStr: &str) -> Result<&'a Room, &'a str> {`
	`33`	`+ \| ++++ ++ ++ ++ ++`
`34`	`34`
`35`	`35`	`error: aborting due to 2 previous errors`
`36`	`36`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ LL \| x`
`11`	`11`	`\|`
`12`	`12`	`help: consider introducing a named lifetime parameter and update trait if needed`
`13`	`13`	`\|`
`14`		`-LL \| fn foo<'a>(&'a self, x: &'a i32) -> &i32 {`
`15`		`- \| ++`
	`14`	`+LL \| fn foo<'a>(&'a self, x: &'a i32) -> &'a i32 {`
	`15`	`+ \| ++ ++`
`16`	`16`
`17`	`17`	`error: aborting due to 1 previous error`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,8 @@ LL \| x`
`10`	`10`	`\|`
`11`	`11`	`help: consider introducing a named lifetime parameter and update trait if needed`
`12`	`12`	`\|`
`13`		`-LL \| fn foo<'a>(&'a self, x: &'a i32) -> &i32 {`
`14`		`- \| ++ ++`
	`13`	`+LL \| fn foo<'a>(&'a self, x: &'a i32) -> &'a i32 {`
	`14`	`+ \| ++ ++ ++`
`15`	`15`
`16`	`16`	`error: aborting due to 1 previous error`
`17`	`17`
Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,8 @@ LL \| if true { x } else { self }`
`10`	`10`	`\|`
`11`	`11`	`help: consider introducing a named lifetime parameter and update trait if needed`
`12`	`12`	`\|`
`13`		`-LL \| fn foo<'a>(&'a self, x: &'a Foo) -> &Foo {`
`14`		`- \| ++ ++`
	`13`	`+LL \| fn foo<'a>(&'a self, x: &'a Foo) -> &'a Foo {`
	`14`	`+ \| ++ ++ ++`
`15`	`15`
`16`	`16`	`error: aborting due to 1 previous error`
`17`	`17`
Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,8 @@ LL \| fn a(self: Pin<&Foo>, f: &Foo) -> &Foo { f }`
`9`	`9`	`\|`
`10`	`10`	`help: consider introducing a named lifetime parameter and update trait if needed`
`11`	`11`	`\|`
`12`		`-LL \| fn a<'a>(self: Pin<&'a Foo>, f: &'a Foo) -> &Foo { f }`
`13`		`- \| ++++ ++ ++`
	`12`	`+LL \| fn a<'a>(self: Pin<&'a Foo>, f: &'a Foo) -> &'a Foo { f }`
	`13`	`+ \| ++++ ++ ++ ++`
`14`	`14`
`15`	`15`	`error: lifetime may not live long enough`
`16`	`16`	`--> $DIR/arbitrary_self_types_pin_lifetime_mismatch.rs:9:69`
`@@ -23,8 +23,8 @@ LL \| fn c(self: Pin<&Self>, f: &Foo, g: &Foo) -> (Pin<&Foo>, &Foo) { (self,`
`23`	`23`	`\|`
`24`	`24`	`help: consider introducing a named lifetime parameter and update trait if needed`
`25`	`25`	`\|`
`26`		`-LL \| fn c<'a>(self: Pin<&'a Self>, f: &'a Foo, g: &Foo) -> (Pin<&Foo>, &Foo) { (self, f) }`
`27`		`- \| ++++ ++ ++`
	`26`	`+LL \| fn c<'a>(self: Pin<&'a Self>, f: &'a Foo, g: &Foo) -> (Pin<&'a Foo>, &'a Foo) { (self, f) }`
	`27`	`+ \| ++++ ++ ++ ++ ++`
`28`	`28`
`29`	`29`	`error: lifetime may not live long enough`
`30`	`30`	`--> $DIR/arbitrary_self_types_pin_lifetime_mismatch.rs:15:58`
`@@ -36,8 +36,8 @@ LL \| fn bar<'a>(self: Alias<&Self>, arg: &'a ()) -> &() { arg }`
`36`	`36`	`\|`
`37`	`37`	`help: consider introducing a named lifetime parameter and update trait if needed`
`38`	`38`	`\|`
`39`		`-LL \| fn bar<'a>(self: Alias<&'a Self>, arg: &'a ()) -> &() { arg }`
`40`		`- \| ++`
	`39`	`+LL \| fn bar<'a>(self: Alias<&'a Self>, arg: &'a ()) -> &'a () { arg }`
	`40`	`+ \| ++ ++`
`41`	`41`
`42`	`42`	`error: aborting due to 3 previous errors`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,8 @@ LL \| f`
`10`	`10`	`\|`
`11`	`11`	`help: consider introducing a named lifetime parameter and update trait if needed`
`12`	`12`	`\|`
`13`		`-LL \| fn ref_self<'a>(&'a self, f: &'a u32) -> &u32 {`
`14`		`- \| ++++ ++ ++`
	`13`	`+LL \| fn ref_self<'a>(&'a self, f: &'a u32) -> &'a u32 {`
	`14`	`+ \| ++++ ++ ++ ++`
`15`	`15`
`16`	`16`	`error: lifetime may not live long enough`
`17`	`17`	`--> $DIR/lt-ref-self.rs:18:9`
`@@ -25,8 +25,8 @@ LL \| f`
`25`	`25`	`\|`
`26`	`26`	`help: consider introducing a named lifetime parameter and update trait if needed`
`27`	`27`	`\|`
`28`		`-LL \| fn ref_Self<'a>(self: &'a Self, f: &'a u32) -> &u32 {`
`29`		`- \| ++++ ++ ++`
	`28`	`+LL \| fn ref_Self<'a>(self: &'a Self, f: &'a u32) -> &'a u32 {`
	`29`	`+ \| ++++ ++ ++ ++`
`30`	`30`
`31`	`31`	`error: lifetime may not live long enough`
`32`	`32`	`--> $DIR/lt-ref-self.rs:23:9`
`@@ -40,8 +40,8 @@ LL \| f`
`40`	`40`	`\|`
`41`	`41`	`help: consider introducing a named lifetime parameter and update trait if needed`
`42`	`42`	`\|`
`43`		`-LL \| fn box_ref_Self<'a>(self: Box<&'a Self>, f: &'a u32) -> &u32 {`
`44`		`- \| ++++ ++ ++`
	`43`	`+LL \| fn box_ref_Self<'a>(self: Box<&'a Self>, f: &'a u32) -> &'a u32 {`
	`44`	`+ \| ++++ ++ ++ ++`
`45`	`45`
`46`	`46`	`error: lifetime may not live long enough`
`47`	`47`	`--> $DIR/lt-ref-self.rs:28:9`
`@@ -55,8 +55,8 @@ LL \| f`
`55`	`55`	`\|`
`56`	`56`	`help: consider introducing a named lifetime parameter and update trait if needed`
`57`	`57`	`\|`
`58`		`-LL \| fn pin_ref_Self<'a>(self: Pin<&'a Self>, f: &'a u32) -> &u32 {`
`59`		`- \| ++++ ++ ++`
	`58`	`+LL \| fn pin_ref_Self<'a>(self: Pin<&'a Self>, f: &'a u32) -> &'a u32 {`
	`59`	`+ \| ++++ ++ ++ ++`
`60`	`60`
`61`	`61`	`error: lifetime may not live long enough`
`62`	`62`	`--> $DIR/lt-ref-self.rs:33:9`
`@@ -70,8 +70,8 @@ LL \| f`
`70`	`70`	`\|`
`71`	`71`	`help: consider introducing a named lifetime parameter and update trait if needed`
`72`	`72`	`\|`
`73`		`-LL \| fn box_box_ref_Self<'a>(self: Box<Box<&'a Self>>, f: &'a u32) -> &u32 {`
`74`		`- \| ++++ ++ ++`
	`73`	`+LL \| fn box_box_ref_Self<'a>(self: Box<Box<&'a Self>>, f: &'a u32) -> &'a u32 {`
	`74`	`+ \| ++++ ++ ++ ++`
`75`	`75`
`76`	`76`	`error: lifetime may not live long enough`
`77`	`77`	`--> $DIR/lt-ref-self.rs:38:9`
`@@ -85,8 +85,8 @@ LL \| f`
`85`	`85`	`\|`
`86`	`86`	`help: consider introducing a named lifetime parameter and update trait if needed`
`87`	`87`	`\|`
`88`		`-LL \| fn box_pin_Self<'a>(self: Box<Pin<&'a Self>>, f: &'a u32) -> &u32 {`
`89`		`- \| ++++ ++ ++`
	`88`	`+LL \| fn box_pin_Self<'a>(self: Box<Pin<&'a Self>>, f: &'a u32) -> &'a u32 {`
	`89`	`+ \| ++++ ++ ++ ++`
`90`	`90`
`91`	`91`	`error: aborting due to 6 previous errors`
`92`	`92`