Skip to content

Commit 175a5ee

Browse files
committed
Fix another goof: consistently use parent directory of target for rule.
(I wonder if there's a better way to write this in the rule itself; i.e. something like `$$(dirname $$@)`. But for now this will do.)
1 parent 495bceb commit 175a5ee

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

mk/host.mk

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ $$(HLIB$(2)_H_$(4))/$(CFG_LIBRUSTC_$(4)): \
4242
$$(HLIB$(2)_H_$(4))/$(CFG_RUSTLLVM_$(4)) \
4343
$$(HCORELIB_DEFAULT$(2)_H_$(4)) \
4444
$$(HSTDLIB_DEFAULT$(2)_H_$(4)) \
45-
| $$(HBIN$(2)_H_$(4))/
45+
| $$(HLIB$(2)_H_$(4))/
4646

4747
@$$(call E, cp: $$@)
4848
$$(Q)cp $$< $$@
@@ -56,7 +56,7 @@ $$(HLIB$(2)_H_$(4))/$(CFG_LIBSYNTAX_$(4)): \
5656
$$(HLIB$(2)_H_$(4))/$(CFG_RUSTLLVM_$(4)) \
5757
$$(HCORELIB_DEFAULT$(2)_H_$(4)) \
5858
$$(HSTDLIB_DEFAULT$(2)_H_$(4)) \
59-
| $$(HBIN$(2)_H_$(4))/
59+
| $$(HLIB$(2)_H_$(4))/
6060
@$$(call E, cp: $$@)
6161
$$(Q)cp $$< $$@
6262
$$(Q)cp -R $$(TLIB$(1)_T_$(4)_H_$(3))/$(LIBSYNTAX_GLOB_$(4)) \
@@ -65,14 +65,14 @@ $$(HLIB$(2)_H_$(4))/$(CFG_LIBSYNTAX_$(4)): \
6565

6666
$$(HLIB$(2)_H_$(4))/$(CFG_RUNTIME_$(4)): \
6767
$$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_RUNTIME_$(4)) \
68-
| $$(HBIN$(2)_H_$(4))/
68+
| $$(HLIB$(2)_H_$(4))/
6969
@$$(call E, cp: $$@)
7070
$$(Q)cp $$< $$@
7171

7272
$$(HLIB$(2)_H_$(4))/$(CFG_CORELIB_$(4)): \
7373
$$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_CORELIB_$(4)) \
7474
$$(HLIB$(2)_H_$(4))/$(CFG_RUNTIME_$(4)) \
75-
| $$(HBIN$(2)_H_$(4))/
75+
| $$(HLIB$(2)_H_$(4))/
7676
@$$(call E, cp: $$@)
7777
$$(Q)cp $$< $$@
7878
# Subtle: We do not let the shell expand $(CORELIB_DSYM_GLOB) directly rather
@@ -90,7 +90,7 @@ $$(HLIB$(2)_H_$(4))/$(CFG_STDLIB_$(4)): \
9090
$$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_STDLIB_$(4)) \
9191
$$(HLIB$(2)_H_$(4))/$(CFG_CORELIB_$(4)) \
9292
$$(HLIB$(2)_H_$(4))/$(CFG_RUNTIME_$(4)) \
93-
| $$(HBIN$(2)_H_$(4))/
93+
| $$(HLIB$(2)_H_$(4))/
9494
@$$(call E, cp: $$@)
9595
$$(Q)cp $$< $$@
9696
$$(Q)cp -R $$(TLIB$(1)_T_$(4)_H_$(3))/$(STDLIB_GLOB_$(4)) \
@@ -100,15 +100,15 @@ $$(HLIB$(2)_H_$(4))/$(CFG_STDLIB_$(4)): \
100100
$$(HLIB$(2)_H_$(4))/libcore.rlib: \
101101
$$(TLIB$(1)_T_$(4)_H_$(3))/libcore.rlib \
102102
$$(HLIB$(2)_H_$(4))/$$(CFG_RUNTIME_$(4)) \
103-
| $$(HBIN$(2)_H_$(4))/
103+
| $$(HLIB$(2)_H_$(4))/
104104
@$$(call E, cp: $$@)
105105
$$(Q)cp $$< $$@
106106

107107
$$(HLIB$(2)_H_$(4))/libstd.rlib: \
108108
$$(TLIB$(1)_T_$(4)_H_$(3))/libstd.rlib \
109109
$$(HLIB$(2)_H_$(4))/libcore.rlib \
110110
$$(HLIB$(2)_H_$(4))/$$(CFG_RUNTIME_$(4)) \
111-
| $$(HBIN$(2)_H_$(4))/
111+
| $$(HLIB$(2)_H_$(4))/
112112
@$$(call E, cp: $$@)
113113
$$(Q)cp $$< $$@
114114

@@ -117,19 +117,22 @@ $$(HLIB$(2)_H_$(4))/librustc.rlib: \
117117
$$(HLIB$(2)_H_$(4))/libcore.rlib \
118118
$$(HLIB$(2)_H_$(4))/libstd.rlib \
119119
$$(HLIB$(2)_H_$(4))/$$(CFG_RUNTIME_$(4)) \
120-
| $$(HBIN$(2)_H_$(4))/
120+
| $$(HLIB$(2)_H_$(4))/
121121
@$$(call E, cp: $$@)
122122
$$(Q)cp $$< $$@
123123

124124
$$(HLIB$(2)_H_$(4))/$(CFG_RUSTLLVM_$(4)): \
125125
$$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_RUSTLLVM_$(4)) \
126-
| $$(HBIN$(2)_H_$(4))/
126+
| $$(HLIB$(2)_H_$(4))/
127127
@$$(call E, cp: $$@)
128128
$$(Q)cp $$< $$@
129129

130130
$$(HBIN$(2)_H_$(4))/:
131131
mkdir -p $$@
132132

133+
$$(HLIB$(2)_H_$(4))/:
134+
mkdir -p $$@
135+
133136
endef
134137

135138
$(foreach t,$(CFG_HOST_TRIPLES), \

mk/target.mk

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ $$(TLIB$(1)_T_$(2)_H_$(3))/$(CFG_LIBRUSTC_$(3)): \
7373
$$(TBIN$(1)_T_$(2)_H_$(3))/rustc$$(X_$(3)): \
7474
$$(DRIVER_CRATE) \
7575
$$(TLIB$(1)_T_$(2)_H_$(3))/$(CFG_LIBRUSTC_$(3)) \
76-
| $$(TLIB$(1)_T_$(2)_H_$(3))/
76+
| $$(TBIN$(1)_T_$(2)_H_$(3))/
7777
@$$(call E, compile_and_link: $$@)
7878
$$(STAGE$(1)_T_$(2)_H_$(3)) --cfg rustc -o $$@ $$<
7979
ifdef CFG_ENABLE_PAX_FLAGS
@@ -83,6 +83,9 @@ endif
8383

8484
endif
8585

86+
$$(TBIN$(1)_T_$(2)_H_$(3))/:
87+
mkdir -p $$@
88+
8689
$$(TLIB$(1)_T_$(2)_H_$(3))/:
8790
mkdir -p $$@
8891

0 commit comments

Comments
 (0)