fix bitv pop

Gankra · Gankra · commit 1b43b2554c85 · 2014-11-29T11:16:54.000-05:00
diff --git a/src/libcollections/bit.rs b/src/libcollections/bit.rs
@@ -836,11 +836,9 @@ impl Bitv {
             None
         } else {
             let ret = self[self.nbits - 1];
-            // If we are unusing a whole word, make sure it is zeroed out
+            // Second rule of Bitv Club
+            self.set(self.nbits - 1, false);
             self.nbits -= 1;
-            if self.nbits % u32::BITS == 0 {
-                self.storage[self.nbits / u32::BITS] = 0;
-            }
             Some(ret)
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -836,11 +836,9 @@ impl Bitv {`
`836`	`836`	`None`
`837`	`837`	`} else {`
`838`	`838`	`let ret = self[self.nbits - 1];`
`839`		`- // If we are unusing a whole word, make sure it is zeroed out`
	`839`	`+ // Second rule of Bitv Club`
	`840`	`+ self.set(self.nbits - 1, false);`
`840`	`841`	`self.nbits -= 1;`
`841`		`- if self.nbits % u32::BITS == 0 {`
`842`		`- self.storage[self.nbits / u32::BITS] = 0;`
`843`		`- }`
`844`	`842`	`Some(ret)`
`845`	`843`	`}`
`846`	`844`	`}`