add a broken_html_links lint

Author: jyn514

src/librustdoc/html/render/context.rs

@@ -6,6 +6,7 @@ use std::rc::Rc;
 use std::sync::mpsc::{channel, Receiver};
 
 use rustc_data_structures::fx::{FxHashMap, FxHashSet};
+use rustc_hir::HirId;
 use rustc_hir::def_id::{DefId, LOCAL_CRATE};
 use rustc_middle::ty::TyCtxt;
 use rustc_session::Session;
@@ -33,6 +34,7 @@ use crate::html::format::{join_with_double_colon, Buffer};
 use crate::html::markdown::{self, plain_text_summary, ErrorCodes, IdMap};
 use crate::html::url_parts_builder::UrlPartsBuilder;
 use crate::html::{layout, sources, static_files};
+use crate::lint::BROKEN_HTML_LINKS;
 use crate::scrape_examples::AllCallLocations;
 use crate::try_err;
 
@@ -174,8 +176,14 @@ impl<'tcx> Context<'tcx> {
 
         let path = self.dst.canonicalize().unwrap();
         let errors: Vec<_> = unavailable_urls(&path, &CheckContext::default()).collect();
+        let tcx = self.tcx();
         for err in errors {
-            self.sess().struct_warn(&err.to_string().replace('\t', "    ")).emit();
+            // self.sess().struct_warn(&err.to_string().replace('\t', "    ")).emit();
+            let msg = err.to_string().replace('\t', "    ");
+            // TODO: map files back to items
+            let hir_id: HirId = todo!();
+            let span = tcx.def_span(tcx.hir().local_def_id(hir_id));
+            self.tcx().struct_span_lint_hir(BROKEN_HTML_LINKS, hir_id, span, msg, |err| err);
         }
     }
 

src/librustdoc/lint.rs

@@ -174,6 +174,17 @@ declare_rustdoc_lint! {
    "codeblock could not be parsed as valid Rust or is empty"
 }
 
+declare_rustdoc_lint! {
+   /// The `broken_html_links` lint detects generated links that are broken.
+   /// Unlike `broken_intra_doc_links`, this also works for manual links.
+   /// This is a `rustdoc` only lint, see the documentation in the [rustdoc book].
+   ///
+   /// [rustdoc book]: ../../../rustdoc/lints.html#broken_html_links
+   BROKEN_HTML_LINKS,
+   Warn,
+   "generated link pointed to an invalid path"
+}
+
 pub(crate) static RUSTDOC_LINTS: Lazy<Vec<&'static Lint>> = Lazy::new(|| {
     vec![
         BROKEN_INTRA_DOC_LINKS,

src/test/rustdoc/broken-link.rs

@@ -0,0 +1 @@
+//! [broken link](./not-here.html)