Add tidy-alphabetical-start/end around feature lists and, in some cases, allow/warn/deny lists

Author: clarfonthey

Diff for: compiler/rustc_arena/src/lib.rs

@@ -11,20 +11,23 @@
     html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/",
     test(no_crate_inject, attr(deny(warnings)))
 )]
+// tidy-alphabetical-start
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
+#![deny(unsafe_op_in_unsafe_fn)]
+#![feature(decl_macro)]
 #![feature(dropck_eyepatch)]
-#![feature(new_uninit)]
 #![feature(maybe_uninit_slice)]
 #![feature(min_specialization)]
-#![feature(decl_macro)]
+#![feature(new_uninit)]
 #![feature(pointer_byte_offsets)]
 #![feature(rustc_attrs)]
-#![cfg_attr(test, feature(test))]
 #![feature(strict_provenance)]
-#![deny(unsafe_op_in_unsafe_fn)]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
+// tidy-alphabetical-end
 #![cfg_attr(not(bootstrap), allow(internal_features))]
-#![allow(clippy::mut_from_ref)] // Arena allocators are one of the places where this pattern is fine.
+#![cfg_attr(test, feature(test))]
+// Arena allocators are one of the places where this pattern is fine.
+#![allow(clippy::mut_from_ref)]
 
 use smallvec::SmallVec;
 

Diff for: compiler/rustc_ast/src/lib.rs

@@ -8,6 +8,9 @@
     html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/",
     test(attr(deny(warnings)))
 )]
+// tidy-alphabetical-start
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
 #![feature(associated_type_bounds)]
 #![feature(box_patterns)]
 #![feature(const_trait_impl)]
@@ -16,9 +19,8 @@
 #![feature(min_specialization)]
 #![feature(negative_impls)]
 #![feature(stmt_expr_attributes)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
 
 #[macro_use]
 extern crate rustc_macros;

Diff for: compiler/rustc_ast_lowering/src/lib.rs

@@ -30,12 +30,14 @@
 //! get confused if the spans from leaf AST nodes occur in multiple places
 //! in the HIR, especially for multiple identifiers.
 
+// tidy-alphabetical-start
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
 #![feature(box_patterns)]
 #![feature(let_chains)]
 #![feature(never_type)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
 
 #[macro_use]
 extern crate tracing;

Diff for: compiler/rustc_ast_passes/src/lib.rs

@@ -4,10 +4,12 @@
 //!
 //! The crate also contains other misc AST visitors, e.g. `node_count` and `show_span`.
 
+// tidy-alphabetical-start
 #![feature(box_patterns)]
 #![feature(if_let_guard)]
 #![feature(iter_is_partitioned)]
 #![feature(let_chains)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
 #![deny(rustc::untranslatable_diagnostic)]
 #![deny(rustc::diagnostic_outside_of_impl)]

Diff for: compiler/rustc_ast_pretty/src/lib.rs

@@ -1,8 +1,10 @@
-#![deny(rustc::untranslatable_diagnostic)]
+// tidy-alphabetical-start
 #![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
 #![feature(associated_type_bounds)]
 #![feature(box_patterns)]
 #![feature(with_negative_coherence)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
 
 mod helpers;

Diff for: compiler/rustc_attr/src/lib.rs

@@ -4,9 +4,11 @@
 //! The goal is to move the definition of `MetaItem` and things that don't need to be in `syntax`
 //! to this crate.
 
-#![feature(let_chains)]
-#![deny(rustc::untranslatable_diagnostic)]
+// tidy-alphabetical-start
 #![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
+#![feature(let_chains)]
+// tidy-alphabetical-end
 
 #[macro_use]
 extern crate rustc_macros;

Diff for: compiler/rustc_borrowck/src/lib.rs

@@ -1,15 +1,17 @@
 //! This query borrow-checks the MIR to (further) ensure it is not broken.
 
+// tidy-alphabetical-start
 #![feature(associated_type_bounds)]
 #![feature(box_patterns)]
+#![feature(lazy_cell)]
 #![feature(let_chains)]
 #![feature(min_specialization)]
 #![feature(never_type)]
-#![feature(lazy_cell)]
 #![feature(rustc_attrs)]
 #![feature(stmt_expr_attributes)]
 #![feature(trusted_step)]
 #![feature(try_blocks)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
 #![cfg_attr(not(bootstrap), allow(internal_features))]
 

Diff for: compiler/rustc_builtin_macros/src/lib.rs

@@ -2,6 +2,7 @@
 //! injecting code into the crate before it is lowered to HIR.
 
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
+// tidy-alphabetical-start
 #![feature(array_windows)]
 #![feature(box_patterns)]
 #![feature(decl_macro)]
@@ -11,6 +12,7 @@
 #![feature(lint_reasons)]
 #![feature(proc_macro_internals)]
 #![feature(proc_macro_quote)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
 
 extern crate proc_macro;

Diff for: compiler/rustc_codegen_cranelift/src/lib.rs

@@ -1,8 +1,10 @@
-#![feature(rustc_private)]
 // Note: please avoid adding other feature gates where possible
+#![feature(rustc_private)]
+// tidy-alphabetical-start
 #![warn(rust_2018_idioms)]
-#![warn(unused_lifetimes)]
 #![warn(unreachable_pub)]
+#![warn(unused_lifetimes)]
+// tidy-alphabetical-end
 
 extern crate jobserver;
 #[macro_use]

Diff for: compiler/rustc_codegen_gcc/src/lib.rs

@@ -6,20 +6,22 @@
  * TODO(antoyo): remove the patches.
  */
 
-#![feature(
-    rustc_private,
-    decl_macro,
-    associated_type_bounds,
-    never_type,
-    trusted_len,
-    hash_raw_entry
-)]
+// tidy-alphabetical-start
 #![allow(broken_intra_doc_links)]
-#![recursion_limit="256"]
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
 #![warn(rust_2018_idioms)]
 #![warn(unused_lifetimes)]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
+// tidy-alphabetical-end
+// tidy-alphabetical-start
+#![feature(associated_type_bounds)]
+#![feature(decl_macro)]
+#![feature(hash_raw_entry)]
+#![feature(never_type)]
+#![feature(rustc_private)]
+#![feature(trusted_len)]
+// tidy-alphabetical-end
+#![recursion_limit="256"]
 
 extern crate rustc_apfloat;
 extern crate rustc_ast;

Diff for: compiler/rustc_codegen_llvm/src/lib.rs

@@ -5,16 +5,18 @@
 //! This API is completely unstable and subject to change.
 
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
+// tidy-alphabetical-start
+#![allow(rustc::potential_query_instability)]
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
 #![feature(extern_types)]
 #![feature(hash_raw_entry)]
+#![feature(impl_trait_in_assoc_type)]
 #![feature(iter_intersperse)]
 #![feature(let_chains)]
 #![feature(never_type)]
-#![feature(impl_trait_in_assoc_type)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
-#![allow(rustc::potential_query_instability)]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
 
 #[macro_use]
 extern crate rustc_macros;

Diff for: compiler/rustc_codegen_ssa/src/lib.rs

@@ -1,4 +1,6 @@
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
+// tidy-alphabetical-start
+#![allow(rustc::potential_query_instability)]
 #![feature(associated_type_bounds)]
 #![feature(box_patterns)]
 #![feature(if_let_guard)]
@@ -7,8 +9,8 @@
 #![feature(never_type)]
 #![feature(strict_provenance)]
 #![feature(try_blocks)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
-#![allow(rustc::potential_query_instability)]
 
 //! This crate contains codegen code that is used by all codegen backends (LLVM and others).
 //! The backend-agnostic functions of this crate use functions defined in various traits that

Diff for: compiler/rustc_const_eval/src/lib.rs

@@ -4,23 +4,25 @@ Rust MIR: a lowered representation of Rust.
 
 */
 
+// tidy-alphabetical-start
 #![deny(rustc::untranslatable_diagnostic)]
 #![feature(assert_matches)]
 #![feature(box_patterns)]
 #![feature(decl_macro)]
 #![feature(exact_size_is_empty)]
+#![feature(if_let_guard)]
 #![feature(let_chains)]
 #![feature(map_try_insert)]
 #![feature(min_specialization)]
-#![feature(slice_ptr_get)]
-#![feature(option_get_or_insert_default)]
 #![feature(never_type)]
+#![feature(option_get_or_insert_default)]
+#![feature(slice_ptr_get)]
 #![feature(trait_alias)]
 #![feature(trusted_len)]
 #![feature(trusted_step)]
 #![feature(try_blocks)]
 #![feature(yeet_expr)]
-#![feature(if_let_guard)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
 
 #[macro_use]

Diff for: compiler/rustc_data_structures/src/lib.rs

@@ -7,38 +7,40 @@
 //! This API is completely unstable and subject to change.
 
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
+// tidy-alphabetical-start
+#![allow(rustc::default_hash_types)]
+#![allow(rustc::potential_query_instability)]
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
+#![deny(unsafe_op_in_unsafe_fn)]
+#![feature(allocator_api)]
 #![feature(array_windows)]
 #![feature(associated_type_bounds)]
 #![feature(auto_traits)]
 #![feature(cell_leak)]
 #![feature(core_intrinsics)]
 #![feature(extend_one)]
+#![feature(get_mut_unchecked)]
 #![feature(hash_raw_entry)]
 #![feature(hasher_prefixfree_extras)]
+#![feature(lazy_cell)]
+#![feature(lint_reasons)]
+#![feature(macro_metavar_expr)]
 #![feature(maybe_uninit_uninit_array)]
 #![feature(min_specialization)]
+#![feature(negative_impls)]
 #![feature(never_type)]
-#![feature(type_alias_impl_trait)]
 #![feature(new_uninit)]
-#![feature(lazy_cell)]
+#![feature(ptr_alignment_type)]
 #![feature(rustc_attrs)]
-#![feature(negative_impls)]
+#![feature(strict_provenance)]
 #![feature(test)]
 #![feature(thread_id_value)]
-#![feature(vec_into_raw_parts)]
-#![feature(allocator_api)]
-#![feature(get_mut_unchecked)]
-#![feature(lint_reasons)]
+#![feature(type_alias_impl_trait)]
 #![feature(unwrap_infallible)]
-#![feature(strict_provenance)]
-#![feature(ptr_alignment_type)]
-#![feature(macro_metavar_expr)]
-#![allow(rustc::default_hash_types)]
-#![allow(rustc::potential_query_instability)]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
+#![feature(vec_into_raw_parts)]
+// tidy-alphabetical-end
 #![cfg_attr(not(bootstrap), allow(internal_features))]
-#![deny(unsafe_op_in_unsafe_fn)]
 
 #[macro_use]
 extern crate tracing;

Diff for: compiler/rustc_error_messages/src/lib.rs

@@ -1,9 +1,11 @@
-#![feature(let_chains)]
+// tidy-alphabetical-start
+#![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
 #![feature(lazy_cell)]
+#![feature(let_chains)]
 #![feature(rustc_attrs)]
 #![feature(type_alias_impl_trait)]
-#![deny(rustc::untranslatable_diagnostic)]
-#![deny(rustc::diagnostic_outside_of_impl)]
+// tidy-alphabetical-end
 #![cfg_attr(not(bootstrap), allow(internal_features))]
 
 #[macro_use]

Diff for: compiler/rustc_errors/src/lib.rs

@@ -3,18 +3,20 @@
 //! This module contains the code for creating and emitting diagnostics.
 
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/nightly-rustc/")]
+// tidy-alphabetical-start
+#![allow(incomplete_features)]
 #![feature(array_windows)]
+#![feature(box_patterns)]
+#![feature(error_reporter)]
 #![feature(extract_if)]
 #![feature(if_let_guard)]
 #![feature(let_chains)]
 #![feature(never_type)]
 #![feature(result_option_inspect)]
 #![feature(rustc_attrs)]
-#![feature(yeet_expr)]
 #![feature(try_blocks)]
-#![feature(box_patterns)]
-#![feature(error_reporter)]
-#![allow(incomplete_features)]
+#![feature(yeet_expr)]
+// tidy-alphabetical-end
 #![cfg_attr(not(bootstrap), allow(internal_features))]
 
 #[macro_use]

Diff for: compiler/rustc_expand/src/lib.rs

@@ -1,3 +1,5 @@
+// tidy-alphabetical-start
+#![deny(rustc::untranslatable_diagnostic)]
 #![feature(array_windows)]
 #![feature(associated_type_bounds)]
 #![feature(associated_type_defaults)]
@@ -9,8 +11,8 @@
 #![feature(proc_macro_span)]
 #![feature(rustc_attrs)]
 #![feature(try_blocks)]
+// tidy-alphabetical-end
 #![recursion_limit = "256"]
-#![deny(rustc::untranslatable_diagnostic)]
 #![cfg_attr(not(bootstrap), allow(internal_features))]
 
 #[macro_use]

Diff for: compiler/rustc_feature/src/lib.rs

@@ -10,10 +10,11 @@
 //! For the purpose of future feature-tracking, once a feature gate is added,
 //! even if it is stabilized or removed, *do not remove it*. Instead, move the
 //! symbol to the `accepted` or `removed` modules respectively.
-
-#![feature(lazy_cell)]
-#![deny(rustc::untranslatable_diagnostic)]
+// tidy-alphabetical-start
 #![deny(rustc::diagnostic_outside_of_impl)]
+#![deny(rustc::untranslatable_diagnostic)]
+#![feature(lazy_cell)]
+// tidy-alphabetical-end
 
 mod accepted;
 mod active;