Skip to content

Commit 2cc52f0

Browse files
committed
Use cmp::Reverse instead of subtraction
1 parent 1aa6152 commit 2cc52f0

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Diff for: src/librustc_mir/monomorphize/partitioning.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ use rustc::ty::{self, TyCtxt, InstanceDef};
112112
use rustc::ty::item_path::characteristic_def_id_of_type;
113113
use rustc::util::nodemap::{FxHashMap, FxHashSet};
114114
use std::collections::hash_map::Entry;
115+
use std::cmp;
115116
use syntax::ast::NodeId;
116117
use syntax::symbol::{Symbol, InternedString};
117118
use rustc::mir::mono::MonoItem;
118119
use monomorphize::item::{MonoItemExt, InstantiationMode};
119-
use core::usize;
120120

121121
pub use rustc::mir::mono::CodegenUnit;
122122

@@ -509,7 +509,7 @@ fn merge_codegen_units<'tcx>(initial_partitioning: &mut PreInliningPartitioning<
509509
// Merge the two smallest codegen units until the target size is reached.
510510
while codegen_units.len() > target_cgu_count {
511511
// Sort small cgus to the back
512-
codegen_units.sort_by_cached_key(|cgu| usize::MAX - cgu.size_estimate());
512+
codegen_units.sort_by_cached_key(|cgu| cmp::Reverse(cgu.size_estimate()));
513513
let mut smallest = codegen_units.pop().unwrap();
514514
let second_smallest = codegen_units.last_mut().unwrap();
515515

Diff for: src/librustc_trans/base.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ use std::ffi::CString;
8282
use std::str;
8383
use std::sync::Arc;
8484
use std::time::{Instant, Duration};
85-
use std::{i32, usize};
85+
use std::i32;
86+
use std::cmp;
8687
use std::sync::mpsc;
8788
use syntax_pos::Span;
8889
use syntax_pos::symbol::InternedString;
@@ -830,7 +831,7 @@ pub fn trans_crate<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>,
830831
// a bit more efficiently.
831832
let codegen_units = {
832833
let mut codegen_units = codegen_units;
833-
codegen_units.sort_by_cached_key(|cgu| usize::MAX - cgu.size_estimate());
834+
codegen_units.sort_by_cached_key(|cgu| cmp::Reverse(cgu.size_estimate()));
834835
codegen_units
835836
};
836837

0 commit comments

Comments
 (0)