Skip to content

Commit

Permalink
Change rebuild heuristic in BinaryHeap::append
Browse files Browse the repository at this point in the history
See #77433 for why the new heuristic was chosen.

Fixes #77433
  • Loading branch information
hanmertens committed Jan 15, 2021
1 parent e48eb37 commit 32a20f4
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions library/alloc/src/collections/binary_heap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -630,10 +630,16 @@ impl<T: Ord> BinaryHeap<T> {
// and about 2 * (len1 + len2) comparisons in the worst case
// while `extend` takes O(len2 * log(len1)) operations
// and about 1 * len2 * log_2(len1) comparisons in the worst case,
// assuming len1 >= len2.
// assuming len1 >= len2. For larger heaps, the crossover point
// no longer follows this reasoning and was determined empirically.
#[inline]
fn better_to_rebuild(len1: usize, len2: usize) -> bool {
2 * (len1 + len2) < len2 * log2_fast(len1)
let tot_len = len1 + len2;
if tot_len <= 2048 {
2 * tot_len < len2 * log2_fast(len1)
} else {
2 * tot_len < len2 * 11
}
}

if better_to_rebuild(self.len(), other.len()) {
Expand Down

0 comments on commit 32a20f4

Please sign in to comment.