ast lowering stuff

Author: BoxyUwU

compiler/rustc_ast_lowering/src/lib.rs

@@ -2413,6 +2413,9 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
                     expr.id,
                     &se.qself,
                     &se.path,
+                    // FIXME(mgca): we may want this to be `Optional` instead, but
+                    // we would also need to make sure that HIR ty lowering errors
+                    // when these paths wind up in signatures.
                     ParamMode::Explicit,
                     AllowReturnTypeNotation::No,
                     ImplTraitContext::Disallowed(ImplTraitPosition::Path),
@@ -2421,6 +2424,9 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
 
                 let fields = self.arena.alloc_from_iter(se.fields.iter().map(|f| {
                     let hir_id = self.lower_node_id(f.id);
+                    // FIXME(mgca): This might result in lowering attributes that
+                    // then go unused as the `Target::ExprField` is not actually
+                    // corresponding to `Node::ExprField`.
                     self.lower_attrs(hir_id, &f.attrs, f.span, Target::ExprField);
 
                     let expr = if let ExprKind::ConstBlock(anon_const) = &f.expr.kind {