Skip to content

Commit 340d1cc

Browse files
committed
Fix tag align tests for 32bit linux (fixes #7340)
1 parent 455aa62 commit 340d1cc

File tree

3 files changed

+27
-33
lines changed

3 files changed

+27
-33
lines changed

src/test/run-pass/tag-align-dyn-u64.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
// ignore-linux #7340 fails on 32-bit Linux
12-
// ignore-macos #7340 fails on 32-bit macos
13-
1411
use std::mem;
1512

1613
enum Tag<A> {
@@ -26,12 +23,13 @@ fn mk_rec() -> Rec {
2623
return Rec { c8:0, t:Tag::Tag2(0) };
2724
}
2825

29-
fn is_8_byte_aligned(u: &Tag<u64>) -> bool {
26+
fn is_u64_aligned(u: &Tag<u64>) -> bool {
3027
let p: uint = unsafe { mem::transmute(u) };
31-
return (p & 7) == 0;
28+
let u64_align = std::mem::min_align_of::<u64>();
29+
return (p & (u64_align - 1)) == 0;
3230
}
3331

3432
pub fn main() {
3533
let x = mk_rec();
36-
assert!(is_8_byte_aligned(&x.t));
34+
assert!(is_u64_aligned(&x.t));
3735
}

src/test/run-pass/tag-align-dyn-variants.rs

+19-21
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
// ignore-linux #7340 fails on 32-bit Linux
12-
// ignore-macos #7340 fails on 32-bit macos
13-
1411
use std::mem;
1512

1613
enum Tag<A,B> {
@@ -42,33 +39,34 @@ fn variant_data_is_aligned<A,B>(amnt: uint, u: &Tag<A,B>) -> bool {
4239
}
4340

4441
pub fn main() {
45-
let x = mk_rec(22, 23);
46-
assert!(is_aligned(8, &x.tA));
47-
assert!(variant_data_is_aligned(8, &x.tA));
48-
assert!(is_aligned(8, &x.tB));
49-
assert!(variant_data_is_aligned(8, &x.tB));
42+
let u64_align = std::mem::min_align_of::<u64>();
43+
let x = mk_rec(22u64, 23u64);
44+
assert!(is_aligned(u64_align, &x.tA));
45+
assert!(variant_data_is_aligned(u64_align, &x.tA));
46+
assert!(is_aligned(u64_align, &x.tB));
47+
assert!(variant_data_is_aligned(u64_align, &x.tB));
5048

51-
let x = mk_rec(22, 23);
52-
assert!(is_aligned(8, &x.tA));
53-
assert!(variant_data_is_aligned(8, &x.tA));
54-
assert!(is_aligned(8, &x.tB));
49+
let x = mk_rec(22u64, 23u32);
50+
assert!(is_aligned(u64_align, &x.tA));
51+
assert!(variant_data_is_aligned(u64_align, &x.tA));
52+
assert!(is_aligned(u64_align, &x.tB));
5553
assert!(variant_data_is_aligned(4, &x.tB));
5654

57-
let x = mk_rec(22, 23);
58-
assert!(is_aligned(8, &x.tA));
55+
let x = mk_rec(22u32, 23u64);
56+
assert!(is_aligned(u64_align, &x.tA));
5957
assert!(variant_data_is_aligned(4, &x.tA));
60-
assert!(is_aligned(8, &x.tB));
61-
assert!(variant_data_is_aligned(8, &x.tB));
58+
assert!(is_aligned(u64_align, &x.tB));
59+
assert!(variant_data_is_aligned(u64_align, &x.tB));
6260

63-
let x = mk_rec(22, 23);
61+
let x = mk_rec(22u32, 23u32);
6462
assert!(is_aligned(4, &x.tA));
6563
assert!(variant_data_is_aligned(4, &x.tA));
6664
assert!(is_aligned(4, &x.tB));
6765
assert!(variant_data_is_aligned(4, &x.tB));
6866

6967
let x = mk_rec(22f64, 23f64);
70-
assert!(is_aligned(8, &x.tA));
71-
assert!(variant_data_is_aligned(8, &x.tA));
72-
assert!(is_aligned(8, &x.tB));
73-
assert!(variant_data_is_aligned(8, &x.tB));
68+
assert!(is_aligned(u64_align, &x.tA));
69+
assert!(variant_data_is_aligned(u64_align, &x.tA));
70+
assert!(is_aligned(u64_align, &x.tB));
71+
assert!(variant_data_is_aligned(u64_align, &x.tB));
7472
}

src/test/run-pass/tag-align-u64.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
// ignore-linux #7340 fails on 32-bit Linux
12-
// ignore-macos #7340 fails on 32-bit macos
13-
1411
use std::mem;
1512

1613
enum Tag {
@@ -26,12 +23,13 @@ fn mk_rec() -> Rec {
2623
return Rec { c8:0, t:Tag::TagInner(0) };
2724
}
2825

29-
fn is_8_byte_aligned(u: &Tag) -> bool {
26+
fn is_u64_aligned(u: &Tag) -> bool {
3027
let p: uint = unsafe { mem::transmute(u) };
31-
return (p & 7) == 0;
28+
let u64_align = std::mem::min_align_of::<u64>();
29+
return (p & (u64_align - 1)) == 0;
3230
}
3331

3432
pub fn main() {
3533
let x = mk_rec();
36-
assert!(is_8_byte_aligned(&x.t));
34+
assert!(is_u64_aligned(&x.t));
3735
}

0 commit comments

Comments
 (0)