Skip to content

Commit 35812d1

Browse files
committed
resolved merge conflicts
2 parents dfb740f + f3fc547 commit 35812d1

File tree

244 files changed

+11479
-2633
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

244 files changed

+11479
-2633
lines changed

.mailmap

+1
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ Margaret Meyerhofer <mmeyerho@andrew.cmu.edu> <mmeyerho@andrew>
139139
Mark Sinclair <mark.edward.x@gmail.com>
140140
Mark Sinclair <mark.edward.x@gmail.com> =Mark Sinclair <=125axel125@gmail.com>
141141
Markus Westerlind <marwes91@gmail.com> Markus <marwes91@gmail.com>
142+
Martin Hafskjold Thoresen <martinhath@gmail.com>
142143
Matej Lach <matej.lach@gmail.com> Matej Ľach <matej.lach@gmail.com>
143144
Matt Brubeck <mbrubeck@limpet.net> <mbrubeck@cs.hmc.edu>
144145
Matthew Auld <matthew.auld@intel.com>

.travis.yml

+13-4
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ matrix:
9595
MACOSX_DEPLOYMENT_TARGET=10.7
9696
os: osx
9797
osx_image: xcode7
98-
install: *osx_install_sccache
98+
install:
99+
- travis_retry brew update
100+
- travis_retry brew install xz
101+
- *osx_install_sccache
99102
- env: >
100103
RUST_CHECK_TARGET=dist
101104
RUST_CONFIGURE_ARGS="--target=aarch64-apple-ios,armv7-apple-ios,armv7s-apple-ios,i386-apple-ios,x86_64-apple-ios --enable-extended --enable-sanitizers"
@@ -106,7 +109,10 @@ matrix:
106109
MACOSX_DEPLOYMENT_TARGET=10.7
107110
os: osx
108111
osx_image: xcode7
109-
install: *osx_install_sccache
112+
install:
113+
- travis_retry brew update
114+
- travis_retry brew install xz
115+
- *osx_install_sccache
110116
111117
# "alternate" deployments, these are "nightlies" but don't have assertions
112118
# turned on, they're deployed to a different location primarily for projects
@@ -123,7 +129,10 @@ matrix:
123129
MACOSX_DEPLOYMENT_TARGET=10.7
124130
os: osx
125131
osx_image: xcode7
126-
install: *osx_install_sccache
132+
install:
133+
- travis_retry brew update
134+
- travis_retry brew install xz
135+
- *osx_install_sccache
127136
128137
env:
129138
global:
@@ -185,7 +194,7 @@ after_failure:
185194

186195
# Save tagged docker images we created and load them if they're available
187196
# Travis saves caches whether the build failed or not, nuke rustsrc if
188-
# the failure was while updating it (as it may be in an bad state)
197+
# the failure was while updating it (as it may be in a bad state)
189198
# https://github.com/travis-ci/travis-ci/issues/4472
190199
before_cache:
191200
- docker history -q rust-ci |

configure

-1
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,6 @@ valopt default-ar "ar" "the default ar"
510510
opt_nosave manage-submodules 1 "let the build manage the git submodules"
511511
opt_nosave clang 0 "prefer clang to gcc for building the runtime"
512512
opt_nosave jemalloc 1 "build liballoc with jemalloc"
513-
opt elf-tls 1 "elf thread local storage on platforms where supported"
514513
opt full-bootstrap 0 "build three compilers instead of two"
515514
opt extended 0 "build an extended rust tool set"
516515

src/Cargo.lock

+10-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/bootstrap/check.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ fn find_tests(dir: &Path,
529529
}
530530
}
531531

532-
pub fn emulator_copy_libs(build: &Build, compiler: &Compiler, target: &str) {
532+
pub fn remote_copy_libs(build: &Build, compiler: &Compiler, target: &str) {
533533
if !build.remote_tested(target) {
534534
return
535535
}

src/bootstrap/step.rs

+18-18
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ pub fn build_rules<'a>(build: &'a Build) -> Rules {
307307
.dep(|s| s.name("libtest"))
308308
.dep(|s| s.name("tool-compiletest").target(s.host).stage(0))
309309
.dep(|s| s.name("test-helpers"))
310-
.dep(|s| s.name("emulator-copy-libs"))
310+
.dep(|s| s.name("remote-copy-libs"))
311311
.default(mode != "pretty") // pretty tests don't run everywhere
312312
.run(move |s| {
313313
check::compiletest(build, &s.compiler(), s.target, mode, dir)
@@ -346,7 +346,7 @@ pub fn build_rules<'a>(build: &'a Build) -> Rules {
346346
.dep(|s| s.name("tool-compiletest").target(s.host).stage(0))
347347
.dep(|s| s.name("test-helpers"))
348348
.dep(|s| s.name("debugger-scripts"))
349-
.dep(|s| s.name("emulator-copy-libs"))
349+
.dep(|s| s.name("remote-copy-libs"))
350350
.run(move |s| check::compiletest(build, &s.compiler(), s.target,
351351
"debuginfo-gdb", "debuginfo"));
352352
let mut rule = rules.test("check-debuginfo", "src/test/debuginfo");
@@ -400,14 +400,14 @@ pub fn build_rules<'a>(build: &'a Build) -> Rules {
400400
for (krate, path, _default) in krates("std") {
401401
rules.test(&krate.test_step, path)
402402
.dep(|s| s.name("libtest"))
403-
.dep(|s| s.name("emulator-copy-libs"))
403+
.dep(|s| s.name("remote-copy-libs"))
404404
.run(move |s| check::krate(build, &s.compiler(), s.target,
405405
Mode::Libstd, TestKind::Test,
406406
Some(&krate.name)));
407407
}
408408
rules.test("check-std-all", "path/to/nowhere")
409409
.dep(|s| s.name("libtest"))
410-
.dep(|s| s.name("emulator-copy-libs"))
410+
.dep(|s| s.name("remote-copy-libs"))
411411
.default(true)
412412
.run(move |s| check::krate(build, &s.compiler(), s.target,
413413
Mode::Libstd, TestKind::Test, None));
@@ -416,44 +416,44 @@ pub fn build_rules<'a>(build: &'a Build) -> Rules {
416416
for (krate, path, _default) in krates("std") {
417417
rules.bench(&krate.bench_step, path)
418418
.dep(|s| s.name("libtest"))
419-
.dep(|s| s.name("emulator-copy-libs"))
419+
.dep(|s| s.name("remote-copy-libs"))
420420
.run(move |s| check::krate(build, &s.compiler(), s.target,
421421
Mode::Libstd, TestKind::Bench,
422422
Some(&krate.name)));
423423
}
424424
rules.bench("bench-std-all", "path/to/nowhere")
425425
.dep(|s| s.name("libtest"))
426-
.dep(|s| s.name("emulator-copy-libs"))
426+
.dep(|s| s.name("remote-copy-libs"))
427427
.default(true)
428428
.run(move |s| check::krate(build, &s.compiler(), s.target,
429429
Mode::Libstd, TestKind::Bench, None));
430430

431431
for (krate, path, _default) in krates("test") {
432432
rules.test(&krate.test_step, path)
433433
.dep(|s| s.name("libtest"))
434-
.dep(|s| s.name("emulator-copy-libs"))
434+
.dep(|s| s.name("remote-copy-libs"))
435435
.run(move |s| check::krate(build, &s.compiler(), s.target,
436436
Mode::Libtest, TestKind::Test,
437437
Some(&krate.name)));
438438
}
439439
rules.test("check-test-all", "path/to/nowhere")
440440
.dep(|s| s.name("libtest"))
441-
.dep(|s| s.name("emulator-copy-libs"))
441+
.dep(|s| s.name("remote-copy-libs"))
442442
.default(true)
443443
.run(move |s| check::krate(build, &s.compiler(), s.target,
444444
Mode::Libtest, TestKind::Test, None));
445445
for (krate, path, _default) in krates("rustc-main") {
446446
rules.test(&krate.test_step, path)
447447
.dep(|s| s.name("librustc"))
448-
.dep(|s| s.name("emulator-copy-libs"))
448+
.dep(|s| s.name("remote-copy-libs"))
449449
.host(true)
450450
.run(move |s| check::krate(build, &s.compiler(), s.target,
451451
Mode::Librustc, TestKind::Test,
452452
Some(&krate.name)));
453453
}
454454
rules.test("check-rustc-all", "path/to/nowhere")
455455
.dep(|s| s.name("librustc"))
456-
.dep(|s| s.name("emulator-copy-libs"))
456+
.dep(|s| s.name("remote-copy-libs"))
457457
.default(true)
458458
.host(true)
459459
.run(move |s| check::krate(build, &s.compiler(), s.target,
@@ -500,17 +500,17 @@ pub fn build_rules<'a>(build: &'a Build) -> Rules {
500500
rules.build("openssl", "path/to/nowhere")
501501
.run(move |s| native::openssl(build, s.target));
502502

503-
// Some test suites are run inside emulators, and most of our test binaries
504-
// are linked dynamically which means we need to ship the standard library
505-
// and such to the emulator ahead of time. This step represents this and is
506-
// a dependency of all test suites.
503+
// Some test suites are run inside emulators or on remote devices, and most
504+
// of our test binaries are linked dynamically which means we need to ship
505+
// the standard library and such to the emulator ahead of time. This step
506+
// represents this and is a dependency of all test suites.
507507
//
508508
// Most of the time this step is a noop (the `check::emulator_copy_libs`
509509
// only does work if necessary). For some steps such as shipping data to
510510
// QEMU we have to build our own tools so we've got conditional dependencies
511-
// on those programs as well. Note that the QEMU client is built for the
512-
// build target (us) and the server is built for the target.
513-
rules.test("emulator-copy-libs", "path/to/nowhere")
511+
// on those programs as well. Note that the remote test client is built for
512+
// the build target (us) and the server is built for the target.
513+
rules.test("remote-copy-libs", "path/to/nowhere")
514514
.dep(|s| s.name("libtest"))
515515
.dep(move |s| {
516516
if build.remote_tested(s.target) {
@@ -526,7 +526,7 @@ pub fn build_rules<'a>(build: &'a Build) -> Rules {
526526
Step::noop()
527527
}
528528
})
529-
.run(move |s| check::emulator_copy_libs(build, &s.compiler(), s.target));
529+
.run(move |s| check::remote_copy_libs(build, &s.compiler(), s.target));
530530

531531
rules.test("check-bootstrap", "src/bootstrap")
532532
.default(true)

src/doc/nomicon

src/doc/rustc-ux-guidelines.md

+13-9
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
% Rustc UX guidelines
22

33
Don't forget the user. Whether human or another program, such as an IDE, a
4-
good user experience with the compiler goes a long way into making developer
5-
lives better. We don't want users to be baffled by compiler output or
4+
good user experience with the compiler goes a long way toward making developers'
5+
lives better. We do not want users to be baffled by compiler output or
66
learn arcane patterns to compile their program.
77

88
## Error, Warning, Help, Note Messages
99

10-
When the compiler detects a problem, it can emit either an error, warning,
11-
note, or help message.
10+
When the compiler detects a problem, it can emit one of the following: an error, a warning,
11+
a note, or a help message.
1212

1313
An `error` is emitted when the compiler detects a problem that makes it unable
1414
to compile the program, either because the program is invalid or the
@@ -17,11 +17,11 @@ An `error` is emitted when the compiler detects a problem that makes it unable
1717
A `warning` is emitted when the compiler detects something odd about a
1818
program. For instance, dead code and unused `Result` values.
1919

20-
A `help` is emitted following either an `error` or `warning` giving extra
20+
A `help` message is emitted following an `error` or `warning` to give additional
2121
information to the user about how to solve their problem.
2222

23-
A `note` is for identifying additional circumstances and parts of the code
24-
that lead to a warning or error. For example, the borrow checker will note any
23+
A `note` is emitted to identify additional circumstances and parts of the code
24+
that caused the warning or error. For example, the borrow checker will note any
2525
previous conflicting borrows.
2626

2727
* Write in plain simple English. If your message, when shown on a – possibly
@@ -56,18 +56,22 @@ Error explanations are long form descriptions of error messages provided with
5656
the compiler. They are accessible via the `--explain` flag. Each explanation
5757
comes with an example of how to trigger it and advice on how to fix it.
5858

59+
Please read [RFC 1567](https://github.com/rust-lang/rfcs/blob/master/text/1567-long-error-codes-explanation-normalization.md)
60+
for details on how to format and write long error codes.
61+
5962
* All of them are accessible [online](http://doc.rust-lang.org/error-index.html),
6063
which are auto-generated from rustc source code in different places:
6164
[librustc](https://github.com/rust-lang/rust/blob/master/src/librustc/diagnostics.rs),
65+
[libsyntax](https://github.com/rust-lang/rust/blob/master/src/libsyntax/diagnostics.rs),
6266
[librustc_borrowck](https://github.com/rust-lang/rust/blob/master/src/librustc_borrowck/diagnostics.rs),
6367
[librustc_const_eval](https://github.com/rust-lang/rust/blob/master/src/librustc_const_eval/diagnostics.rs),
64-
[librustc_lint](https://github.com/rust-lang/rust/blob/master/src/librustc_lint/types.rs),
6568
[librustc_metadata](https://github.com/rust-lang/rust/blob/master/src/librustc_metadata/diagnostics.rs),
6669
[librustc_mir](https://github.com/rust-lang/rust/blob/master/src/librustc_mir/diagnostics.rs),
6770
[librustc_passes](https://github.com/rust-lang/rust/blob/master/src/librustc_passes/diagnostics.rs),
6871
[librustc_privacy](https://github.com/rust-lang/rust/blob/master/src/librustc_privacy/diagnostics.rs),
6972
[librustc_resolve](https://github.com/rust-lang/rust/blob/master/src/librustc_resolve/diagnostics.rs),
7073
[librustc_trans](https://github.com/rust-lang/rust/blob/master/src/librustc_trans/diagnostics.rs),
74+
[librustc_plugin](https://github.com/rust-lang/rust/blob/master/src/librustc_plugin/diagnostics.rs),
7175
[librustc_typeck](https://github.com/rust-lang/rust/blob/master/src/librustc_typeck/diagnostics.rs).
7276
* Explanations have full markdown support. Use it, especially to highlight
7377
code with backticks.
@@ -79,7 +83,7 @@ code with backticks.
7983
* Flags should be orthogonal to each other. For example, if we'd have a
8084
json-emitting variant of multiple actions `foo` and `bar`, an additional
8185
--json flag is better than adding `--foo-json` and `--bar-json`.
82-
* Always give options a long descriptive name, if only for better
86+
* Always give options a long descriptive name, if only for more
8387
understandable compiler scripts.
8488
* The `--verbose` flag is for adding verbose information to `rustc` output
8589
when not compiling a program. For example, using it with the `--version` flag

0 commit comments

Comments
 (0)