Skip to content

Commit 3b64cf6

Browse files
committed
Update E0428 to new format
1 parent 413ada3 commit 3b64cf6

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/librustc_resolve/lib.rs

+5-1
Original file line numberDiff line numberDiff line change
@@ -3382,7 +3382,11 @@ impl<'a> Resolver<'a> {
33823382
},
33833383
(true, _) | (_, true) => struct_span_err!(self.session, span, E0260, "{}", msg),
33843384
_ => match (old_binding.is_import(), binding.is_import()) {
3385-
(false, false) => struct_span_err!(self.session, span, E0428, "{}", msg),
3385+
(false, false) => {
3386+
let mut e = struct_span_err!(self.session, span, E0428, "{}", msg);
3387+
e.span_label(span, &format!("already defined"));
3388+
e
3389+
},
33863390
(true, true) => {
33873391
let mut e = struct_span_err!(self.session, span, E0252, "{}", msg);
33883392
e.span_label(span, &format!("already imported"));

src/test/compile-fail/E0428.rs

+5-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
struct Bar;
11+
struct Bar; //~ previous definition of `Bar` here
12+
//~| previous definition of `Bar` here
1213
struct Bar; //~ ERROR E0428
13-
//~^ ERROR E0428
14+
//~| NOTE already defined
15+
//~| ERROR E0428
16+
//~| NOTE already defined
1417

1518
fn main () {
1619
}

0 commit comments

Comments
 (0)