Arbitrary self types v2: stabilize test changes

All the test changes necessary for stabilization here.

Author: adetaylor

tests/auxiliary/minicore.rs

@@ -31,11 +31,6 @@ macro_rules! impl_marker_trait {
 #[lang = "sized"]
 pub trait Sized {}
 
-#[lang = "legacy_receiver"]
-pub trait LegacyReceiver {}
-impl<T: ?Sized> LegacyReceiver for &T {}
-impl<T: ?Sized> LegacyReceiver for &mut T {}
-
 #[lang = "copy"]
 pub trait Copy: Sized {}
 

tests/codegen/avr/avr-func-addrspace.rs

@@ -9,7 +9,7 @@
 // It also validates that functions can be called through function pointers
 // through traits.
 
-#![feature(no_core, lang_items, intrinsics, unboxed_closures, arbitrary_self_types)]
+#![feature(no_core, lang_items, intrinsics, unboxed_closures)]
 #![crate_type = "lib"]
 #![no_core]
 
@@ -18,8 +18,6 @@ pub trait Sized {}
 #[lang = "copy"]
 pub trait Copy {}
 impl<T: ?Sized> Copy for *const T {}
-#[lang = "legacy_receiver"]
-pub trait LegacyReceiver {}
 #[lang = "tuple_trait"]
 pub trait Tuple {}
 

tests/codegen/sanitizer/kcfi/emit-type-metadata-trait-objects.rs

@@ -8,16 +8,14 @@
 //@ compile-flags: -Cno-prepopulate-passes -Zsanitizer=kcfi -Copt-level=0
 
 #![crate_type = "lib"]
-#![feature(arbitrary_self_types, no_core, lang_items)]
+#![feature(no_core, lang_items)]
 #![no_core]
 
 #[lang = "sized"]
 trait Sized {}
 #[lang = "copy"]
 trait Copy {}
 impl<T: ?Sized> Copy for &T {}
-#[lang = "legacy_receiver"]
-trait LegacyReceiver {}
 #[lang = "dispatch_from_dyn"]
 trait DispatchFromDyn<T> {}
 impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<&'a U> for &'a T {}

tests/ui/async-await/issues/issue-53249.rs

@@ -1,8 +1,6 @@
 //@ check-pass
 //@ edition:2018
 
-#![feature(arbitrary_self_types)]
-
 use std::task::{self, Poll};
 use std::future::Future;
 use std::marker::Unpin;

tests/ui/deriving/deriving-coerce-pointee-neg.rs

@@ -1,4 +1,4 @@
-#![feature(derive_coerce_pointee, arbitrary_self_types)]
+#![feature(derive_coerce_pointee)]
 
 extern crate core;
 use std::marker::CoercePointee;

tests/ui/deriving/deriving-coerce-pointee.rs

@@ -1,5 +1,5 @@
 //@ run-pass
-#![feature(derive_coerce_pointee, arbitrary_self_types)]
+#![feature(derive_coerce_pointee)]
 
 use std::marker::CoercePointee;
 

tests/ui/feature-gates/feature-gate-arbitrary-self-types.rs

@@ -1,6 +1,6 @@
 // Check that a self parameter type requires a DispatchFromDyn impl to be dyn-compatible.
 
-#![feature(arbitrary_self_types, unsize, coerce_unsized)]
+#![feature(unsize, coerce_unsized)]
 
 use std::{
     marker::Unsize,

tests/ui/feature-gates/feature-gate-arbitrary-self-types.stderr

@@ -4,7 +4,7 @@
 struct Struct;
 impl Struct {
     async fn box_ref_Struct(self: Box<Self, impl FnMut(&mut Self)>) -> &u32 {
-    //~^ ERROR Box<Struct, impl FnMut(&mut Self)>` cannot be used as the type of `self` without
+        //~^ ERROR the trait bound
         &1
     }
 }

tests/ui/feature-gates/feature-gate-dispatch-from-dyn-missing-impl.rs

@@ -1,14 +1,16 @@
-error[E0658]: `Box<Struct, impl FnMut(&mut Self)>` cannot be used as the type of `self` without the `arbitrary_self_types` feature
+error[E0277]: the trait bound `impl FnMut(&mut Self): Allocator` is not satisfied
   --> $DIR/could-not-resolve-issue-121503.rs:6:35
    |
 LL |     async fn box_ref_Struct(self: Box<Self, impl FnMut(&mut Self)>) -> &u32 {
-   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Allocator` is not implemented for `impl FnMut(&mut Self)`
    |
-   = note: see issue #44874 <https://github.com/rust-lang/rust/issues/44874> for more information
-   = help: add `#![feature(arbitrary_self_types)]` to the crate attributes to enable
-   = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date
-   = help: consider changing to `self`, `&self`, `&mut self`, or a type implementing `Receiver` such as `self: Box<Self>`, `self: Rc<Self>`, or `self: Arc<Self>`
+note: required by a bound in `Box`
+  --> $SRC_DIR/alloc/src/boxed.rs:LL:COL
+help: consider further restricting this bound
+   |
+LL |     async fn box_ref_Struct(self: Box<Self, impl FnMut(&mut Self) + std::alloc::Allocator>) -> &u32 {
+   |                                                                   +++++++++++++++++++++++
 
 error: aborting due to 1 previous error
 
-For more information about this error, try `rustc --explain E0658`.
+For more information about this error, try `rustc --explain E0277`.

tests/ui/lifetimes/could-not-resolve-issue-121503.rs

@@ -1,5 +1,4 @@
 #![deny(unused_must_use)]
-#![feature(arbitrary_self_types)]
 
 use std::iter::Iterator;
 use std::future::Future;

tests/ui/lifetimes/could-not-resolve-issue-121503.stderr

@@ -1,5 +1,5 @@
 error: unused implementer of `Iterator` that must be used
-  --> $DIR/must_use-in-stdlib-traits.rs:42:4
+  --> $DIR/must_use-in-stdlib-traits.rs:41:4
    |
 LL |    iterator();
    |    ^^^^^^^^^^
@@ -12,31 +12,31 @@ LL | #![deny(unused_must_use)]
    |         ^^^^^^^^^^^^^^^
 
 error: unused implementer of `Future` that must be used
-  --> $DIR/must_use-in-stdlib-traits.rs:43:4
+  --> $DIR/must_use-in-stdlib-traits.rs:42:4
    |
 LL |    future();
    |    ^^^^^^^^
    |
    = note: futures do nothing unless you `.await` or poll them
 
 error: unused implementer of `FnOnce` that must be used
-  --> $DIR/must_use-in-stdlib-traits.rs:44:4
+  --> $DIR/must_use-in-stdlib-traits.rs:43:4
    |
 LL |    square_fn_once();
    |    ^^^^^^^^^^^^^^^^
    |
    = note: closures are lazy and do nothing unless called
 
 error: unused implementer of `FnMut` that must be used
-  --> $DIR/must_use-in-stdlib-traits.rs:45:4
+  --> $DIR/must_use-in-stdlib-traits.rs:44:4
    |
 LL |    square_fn_mut();
    |    ^^^^^^^^^^^^^^^
    |
    = note: closures are lazy and do nothing unless called
 
 error: unused implementer of `Fn` that must be used
-  --> $DIR/must_use-in-stdlib-traits.rs:46:4
+  --> $DIR/must_use-in-stdlib-traits.rs:45:4
    |
 LL |    square_fn();
    |    ^^^^^^^^^^^

tests/ui/lint/unused/must_use-in-stdlib-traits.rs

@@ -1,7 +1,5 @@
 //@ edition: 2018
 
-#![feature(arbitrary_self_types)]
-
 // tests that the referent type of a reference must be known to call methods on it
 
 struct SmartPtr<T>(T);

tests/ui/lint/unused/must_use-in-stdlib-traits.stderr

@@ -1,17 +1,17 @@
 error[E0282]: type annotations needed
-  --> $DIR/call_method_unknown_referent.rs:20:31
+  --> $DIR/call_method_unknown_referent.rs:18:31
    |
 LL |     let _a: i32 = (ptr as &_).read();
    |                               ^^^^ cannot infer type
 
 error[E0282]: type annotations needed
-  --> $DIR/call_method_unknown_referent.rs:26:37
+  --> $DIR/call_method_unknown_referent.rs:24:37
    |
 LL |     let _b = (rc as std::rc::Rc<_>).read();
    |                                     ^^^^ cannot infer type
 
 error[E0599]: no method named `read` found for struct `SmartPtr` in the current scope
-  --> $DIR/call_method_unknown_referent.rs:46:35
+  --> $DIR/call_method_unknown_referent.rs:44:35
    |
 LL | struct SmartPtr<T>(T);
    | ------------------ method `read` not found for this struct

tests/ui/methods/call_method_unknown_referent.rs

@@ -1,8 +1,6 @@
 //@ edition: 2018
 //@ run-pass
 
-#![feature(arbitrary_self_types)]
-
 // tests that the referent type of a reference must be known to call methods on it
 
 struct SmartPtr<T>(T);

tests/ui/methods/call_method_unknown_referent.stderr

@@ -1,4 +1,4 @@
-#![feature(arbitrary_self_types, coerce_unsized, dispatch_from_dyn, unsize)]
+#![feature(coerce_unsized, dispatch_from_dyn, unsize)]
 #![feature(unsized_locals, unsized_fn_params)]
 //~^ WARN the feature `unsized_locals` is incomplete
 

tests/ui/methods/call_method_unknown_referent2.rs

@@ -12,15 +12,10 @@ pub trait Deref {
     type Target;
 }
 
-#[lang="legacy_receiver"]
-pub trait LegacyReceiver: Deref {}
-
 impl<'a, T> Deref for &'a T {
     type Target = T;
 }
 
-impl<'a, T> LegacyReceiver for &'a T {}
-
 mod bar {
     // shouldn't bring in too much
     pub use self::glob::*;