Rollup merge of #98491 - antoyo:fix/ui-test-backtrace-panic-abort, r=Dylan-DPC

matthiaskrgr · web-flow · commit 3efe25f5523e · 2022-06-25T20:07:08.000+02:00
Fix backtrace UI test when panic=abort is used

The function `contains_verbose_expected` is only used when the panic strategy is not abort, so it caused a warning when it was abort, which made the UI test failed on stderr comparison.
diff --git a/src/test/ui/backtrace.rs b/src/test/ui/backtrace.rs
@@ -43,6 +43,7 @@ fn expected(fn_name: &str) -> String {
     format!(" backtrace::{}", fn_name)
 }
 
+#[cfg(not(panic = "abort"))]
 fn contains_verbose_expected(s: &str, fn_name: &str) -> bool {
     // HACK(eddyb) work around the fact that verbosely demangled stack traces
     // (from `RUST_BACKTRACE=full`, or, as is the case here, panic-in-panic)

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ fn expected(fn_name: &str) -> String {`
`43`	`43`	`format!(" backtrace::{}", fn_name)`
`44`	`44`	`}`
`45`	`45`
	`46`	`+#[cfg(not(panic = "abort"))]`
`46`	`47`	`fn contains_verbose_expected(s: &str, fn_name: &str) -> bool {`
`47`	`48`	`// HACK(eddyb) work around the fact that verbosely demangled stack traces`
`48`	`49`	// (from `RUST_BACKTRACE=full`, or, as is the case here, panic-in-panic)