Skip to content

Commit 3f45fe3

Browse files
authored
Rollup merge of #104424 - notriddle:notriddle/popover-font-size, r=GuillaumeGomez
rustdoc: remove no-op CSS `.popover { font-size: 1rem }` This rule was added in cc4f804 because the help popover inherited the font-size from the help button "?" icon. It doesn't inherit this any more, because it was moved from being nested inside the link to sharing a wrapper DIV with it.
2 parents 2dc923a + bd84709 commit 3f45fe3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/librustdoc/html/static/css/rustdoc.css

-2
Original file line numberDiff line numberDiff line change
@@ -920,15 +920,13 @@ so that we can apply CSS-filters to change the arrow color in themes */
920920
}
921921

922922
.popover {
923-
font-size: 1rem;
924923
position: absolute;
925924
right: 0;
926925
z-index: 2;
927926
display: block;
928927
margin-top: 7px;
929928
border-radius: 3px;
930929
border: 1px solid var(--border-color);
931-
font-size: 1rem;
932930
--popover-arrow-offset: 11px;
933931
}
934932

src/test/rustdoc-gui/help-page.goml

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ goto: "file://" + |DOC_PATH| + "/help.html"
33
size: (1000, 1000) // Try desktop size first.
44
wait-for: "#help"
55
assert-css: ("#help", {"display": "block"})
6+
assert-css: ("#help dd", {"font-size": "16px"})
67
click: "#help-button > a"
78
assert-css: ("#help", {"display": "block"})
89
compare-elements-property: (".sub", "#help", ["offsetWidth"])
@@ -18,6 +19,7 @@ size: (1000, 1000) // Only supported on desktop.
1819
assert-false: "#help"
1920
click: "#help-button > a"
2021
assert-css: ("#help", {"display": "block"})
22+
assert-css: ("#help dd", {"font-size": "16px"})
2123
click: "#help-button > a"
2224
assert-css: ("#help", {"display": "none"})
2325
compare-elements-property-false: (".sub", "#help", ["offsetWidth"])

0 commit comments

Comments
 (0)