Skip to content

Commit 43f83bc

Browse files
committed
Move submodule checkout before msys2 installation.
For some reason, `tar` behaves differently in such a way that it does not create symlinks on Windows correctly, resulting in `Cannot create symlink to 'ld.gold': No such file or directory` errors.
1 parent 31267e8 commit 43f83bc

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

.github/workflows/ci.yml

+9-9
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,9 @@ jobs:
104104
- name: disable git crlf conversion
105105
run: src/ci/scripts/disable-git-crlf-conversion.sh
106106
if: success() && !env.SKIP_JOB
107+
- name: checkout submodules
108+
run: src/ci/scripts/checkout-submodules.sh
109+
if: success() && !env.SKIP_JOB
107110
- name: install MSYS2
108111
run: src/ci/scripts/install-msys2.sh
109112
if: success() && !env.SKIP_JOB
@@ -119,9 +122,6 @@ jobs:
119122
- name: disable git crlf conversion
120123
run: src/ci/scripts/disable-git-crlf-conversion.sh
121124
if: success() && !env.SKIP_JOB
122-
- name: checkout submodules
123-
run: src/ci/scripts/checkout-submodules.sh
124-
if: success() && !env.SKIP_JOB
125125
- name: ensure line endings are correct
126126
run: src/ci/scripts/verify-line-endings.sh
127127
if: success() && !env.SKIP_JOB
@@ -502,6 +502,9 @@ jobs:
502502
- name: disable git crlf conversion
503503
run: src/ci/scripts/disable-git-crlf-conversion.sh
504504
if: success() && !env.SKIP_JOB
505+
- name: checkout submodules
506+
run: src/ci/scripts/checkout-submodules.sh
507+
if: success() && !env.SKIP_JOB
505508
- name: install MSYS2
506509
run: src/ci/scripts/install-msys2.sh
507510
if: success() && !env.SKIP_JOB
@@ -517,9 +520,6 @@ jobs:
517520
- name: disable git crlf conversion
518521
run: src/ci/scripts/disable-git-crlf-conversion.sh
519522
if: success() && !env.SKIP_JOB
520-
- name: checkout submodules
521-
run: src/ci/scripts/checkout-submodules.sh
522-
if: success() && !env.SKIP_JOB
523523
- name: ensure line endings are correct
524524
run: src/ci/scripts/verify-line-endings.sh
525525
if: success() && !env.SKIP_JOB
@@ -615,6 +615,9 @@ jobs:
615615
- name: disable git crlf conversion
616616
run: src/ci/scripts/disable-git-crlf-conversion.sh
617617
if: success() && !env.SKIP_JOB
618+
- name: checkout submodules
619+
run: src/ci/scripts/checkout-submodules.sh
620+
if: success() && !env.SKIP_JOB
618621
- name: install MSYS2
619622
run: src/ci/scripts/install-msys2.sh
620623
if: success() && !env.SKIP_JOB
@@ -630,9 +633,6 @@ jobs:
630633
- name: disable git crlf conversion
631634
run: src/ci/scripts/disable-git-crlf-conversion.sh
632635
if: success() && !env.SKIP_JOB
633-
- name: checkout submodules
634-
run: src/ci/scripts/checkout-submodules.sh
635-
if: success() && !env.SKIP_JOB
636636
- name: ensure line endings are correct
637637
run: src/ci/scripts/verify-line-endings.sh
638638
if: success() && !env.SKIP_JOB

src/ci/github-actions/ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,10 @@ x--expand-yaml-anchors--remove:
169169
run: src/ci/scripts/disable-git-crlf-conversion.sh
170170
<<: *step
171171

172+
- name: checkout submodules
173+
run: src/ci/scripts/checkout-submodules.sh
174+
<<: *step
175+
172176
- name: install MSYS2
173177
run: src/ci/scripts/install-msys2.sh
174178
<<: *step
@@ -194,10 +198,6 @@ x--expand-yaml-anchors--remove:
194198
run: src/ci/scripts/disable-git-crlf-conversion.sh
195199
<<: *step
196200

197-
- name: checkout submodules
198-
run: src/ci/scripts/checkout-submodules.sh
199-
<<: *step
200-
201201
- name: ensure line endings are correct
202202
run: src/ci/scripts/verify-line-endings.sh
203203
<<: *step

0 commit comments

Comments
 (0)