Skip to content

Commit 448be39

Browse files
committed
Don't print "command failed" unless the build is verbose
The full command isn't very helpful to the user; it still needs additional environment variables to be run, and it usually doesn't offer much more info about what went wrong. Hide it behind `--verbose`.
1 parent 3bd6cdf commit 448be39

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/bootstrap/compile.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1359,11 +1359,11 @@ pub fn stream_cargo(
13591359
// Make sure Cargo actually succeeded after we read all of its stdout.
13601360
let status = t!(child.wait());
13611361
if !status.success() {
1362-
eprintln!(
1362+
builder.build.verbose(&format!(
13631363
"command did not execute successfully: {:?}\n\
13641364
expected success, got: {}",
13651365
cargo, status
1366-
);
1366+
));
13671367
}
13681368
status.success()
13691369
}

0 commit comments

Comments
 (0)