Skip to content

Commit 4797fba

Browse files
committed
add FIXME for making the cargo cmd properly typed
1 parent 288daeb commit 4797fba

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/bootstrap/src/core/builder.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -1318,7 +1318,7 @@ impl<'a> Builder<'a> {
13181318
compiler: Compiler,
13191319
mode: Mode,
13201320
target: TargetSelection,
1321-
cmd: &str,
1321+
cmd: &str, // FIXME make this properly typed
13221322
) -> Command {
13231323
let mut cargo;
13241324
if cmd == "clippy" {
@@ -1392,7 +1392,7 @@ impl<'a> Builder<'a> {
13921392
mode: Mode,
13931393
source_type: SourceType,
13941394
target: TargetSelection,
1395-
cmd: &str,
1395+
cmd: &str, // FIXME make this properly typed
13961396
) -> Cargo {
13971397
let mut cargo = self.bare_cargo(compiler, mode, target, cmd);
13981398
let out_dir = self.stage_out(compiler, mode);
@@ -2100,7 +2100,7 @@ impl<'a> Builder<'a> {
21002100
rustflags.arg("-Zinline-mir");
21012101
}
21022102

2103-
if builder.config.rustc_parallel
2103+
if self.config.rustc_parallel
21042104
&& matches!(mode, Mode::ToolRustc | Mode::Rustc | Mode::Codegen)
21052105
{
21062106
// keep in sync with `bootstrap/lib.rs:Build::rustc_features`
@@ -2342,7 +2342,7 @@ impl Cargo {
23422342
mode: Mode,
23432343
source_type: SourceType,
23442344
target: TargetSelection,
2345-
cmd: &str,
2345+
cmd: &str, // FIXME make this properly typed
23462346
) -> Cargo {
23472347
let mut cargo = builder.cargo(compiler, mode, source_type, target, cmd);
23482348
cargo.configure_linker(builder);
@@ -2356,7 +2356,7 @@ impl Cargo {
23562356
mode: Mode,
23572357
source_type: SourceType,
23582358
target: TargetSelection,
2359-
cmd: &str,
2359+
cmd: &str, // FIXME make this properly typed
23602360
) -> Cargo {
23612361
builder.cargo(compiler, mode, source_type, target, cmd)
23622362
}

0 commit comments

Comments
 (0)