Skip to content

Commit 4aed1ab

Browse files
committed
Auto merge of #88977 - ehuss:disable-validate-maintainers, r=Mark-Simulacrum
Disable validate_maintainers. The validate_maintainers check has started to fail with the error: ``` HTTPError: HTTP Error 403: Forbidden b'{"message":"Must have admin access to view repository collaborators.","documentation_url":"https://docs.github.com/rest/reference/repos#list-repository-collaborators"}' ``` Apparently GitHub has restricted the collaborators API to admins. For now, this just disables the check to get CI working again. Eventually, I think we'll just need to remove the check since we will unlikely use an admin token, and I don't see a workaround. The `MAINTAINERS` list doesn't change often, so we may just need to put a sternly worded comment near the list.
2 parents 2c7bc5e + 66a1987 commit 4aed1ab

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/test/debuginfo/mutex.rs

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// cdb-only
44
// min-cdb-version: 10.0.21287.1005
55
// compile-flags:-g
6+
// FIXME: Failed on update to 10.0.22000.1
7+
// ignore-windows
68

79
// === CDB TESTS ==================================================================================
810
//

src/tools/publish_toolstate.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,13 @@ def update_latest(
299299
if repo:
300300
github_token = os.environ.get('TOOLSTATE_REPO_ACCESS_TOKEN')
301301
if github_token:
302-
validate_maintainers(repo, github_token)
302+
# FIXME: This is currently broken. Starting on 2021-09-15, GitHub
303+
# seems to have changed it so that to list the collaborators
304+
# requires admin permissions. I think this will probably just need
305+
# to be removed since we are probably not going to use an admin
306+
# token, and I don't see another way to do this.
307+
print('maintainer validation disabled')
308+
# validate_maintainers(repo, github_token)
303309
else:
304310
print('skipping toolstate maintainers validation since no GitHub token is present')
305311
# When validating maintainers don't run the full script.

0 commit comments

Comments
 (0)