Skip to content

Commit 4fd3b12

Browse files
authoredJul 5, 2024··
Rollup merge of #127359 - GuillaumeGomez:improve-run-make-llvm-ident-code, r=jieyouxu
Improve run make llvm ident code I took the commits that are not blocking #127237. r? `@Kobzol`
2 parents e4d7f7c + 415e202 commit 4fd3b12

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
 

‎src/tools/run-make-support/src/command.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,12 @@ impl Command {
7575
/// Generic command arguments provider. Prefer specific helper methods if possible.
7676
/// Note that for some executables, arguments might be platform specific. For C/C++
7777
/// compilers, arguments might be platform *and* compiler specific.
78-
pub fn args<S>(&mut self, args: &[S]) -> &mut Self
78+
pub fn args<S, V>(&mut self, args: V) -> &mut Self
7979
where
8080
S: AsRef<ffi::OsStr>,
81+
V: AsRef<[S]>,
8182
{
82-
self.cmd.args(args);
83+
self.cmd.args(args.as_ref());
8384
self
8485
}
8586

‎tests/run-make/llvm-ident/rmake.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ fn main() {
2828
files.push(path.to_path_buf());
2929
}
3030
});
31-
cmd(llvm_bin_dir().join("llvm-dis")).args(&files).run();
31+
cmd(llvm_bin_dir().join("llvm-dis")).args(files).run();
3232

3333
// Check LLVM IR files (including temporary outputs) have `!llvm.ident`
3434
// named metadata, reusing the related codegen test.

0 commit comments

Comments
 (0)
Please sign in to comment.