removed gate and added test for drop order

Author: Kivooeo

compiler/rustc_parse/src/parser/expr.rs

@@ -3407,31 +3407,19 @@ impl<'a> Parser<'a> {
     fn parse_match_arm_guard(&mut self) -> PResult<'a, Option<P<Expr>>> {
         // Used to check the `if_let_guard` feature mostly by scanning
         // `&&` tokens.
-        fn has_let_expr(expr: &Expr) -> bool {
-            match &expr.kind {
-                ExprKind::Binary(BinOp { node: BinOpKind::And, .. }, lhs, rhs) => {
-                    let lhs_rslt = has_let_expr(lhs);
-                    let rhs_rslt = has_let_expr(rhs);
-                    lhs_rslt || rhs_rslt
-                }
-                ExprKind::Let(..) => true,
-                _ => false,
-            }
-        }
         if !self.eat_keyword(exp!(If)) {
             // No match arm guard present.
             return Ok(None);
         }
 
-        let if_span = self.prev_token.span;
         let mut cond = self.parse_match_guard_condition()?;
 
-        CondChecker::new(self, LetChainsPolicy::AlwaysAllowed).visit_expr(&mut cond);
+        CondChecker::new(
+            self,
+            LetChainsPolicy::EditionDependent { current_edition: Edition::Edition2024 },
+        )
+        .visit_expr(&mut cond);
 
-        if has_let_expr(&cond) {
-            let span = if_span.to(cond.span);
-            self.psess.gated_spans.gate(sym::if_let_guard, span);
-        }
         Ok(Some(cond))
     }
 

tests/ui/drop/drop-order-comparisons.e2021.fixed

@@ -24,7 +24,6 @@
 //@ [e2024] edition: 2024
 //@ run-pass
 
-#![feature(if_let_guard)]
 #![cfg_attr(e2021, feature(let_chains))]
 #![cfg_attr(e2021, warn(rust_2024_compatibility))]
 
@@ -613,4 +612,4 @@ impl<'b> Drop for LogDrop<'b> {
     fn drop(&mut self) {
         self.0.mark(self.1);
     }
-}
+}