File tree 2 files changed +12
-8
lines changed
src/bootstrap/src/core/build_steps
2 files changed +12
-8
lines changed Original file line number Diff line number Diff line change @@ -1424,7 +1424,7 @@ impl Step for Coverage {
1424
1424
const ONLY_HOSTS : bool = false ;
1425
1425
1426
1426
fn should_run ( run : ShouldRun < ' _ > ) -> ShouldRun < ' _ > {
1427
- run. alias ( Self :: SUITE )
1427
+ run. suite_path ( Self :: PATH )
1428
1428
}
1429
1429
1430
1430
fn make_run ( run : RunConfig < ' _ > ) {
@@ -1439,6 +1439,7 @@ impl Step for Coverage {
1439
1439
}
1440
1440
}
1441
1441
1442
+ // Aliases for running the coverage tests in only one mode.
1442
1443
coverage_test_alias ! ( CoverageMap {
1443
1444
mode: "coverage-map" ,
1444
1445
alias: "coverage-map" ,
Original file line number Diff line number Diff line change 1
- Many of these tests were copied from ` tests/run-coverage ` in order to
2
- capture the current behavior of the instrumentor on non-trivial programs.
3
- The actual mappings have not been closely inspected.
1
+ The tests in this directory are shared by two different test modes, and can be
2
+ run in multiple different ways:
3
+
4
+ - ` ./x.py test coverage-map ` (compiles to LLVM IR and checks coverage mappings)
5
+ - ` ./x.py test run-coverage ` (runs a test binary and checks its coverage report)
6
+ - ` ./x.py test coverage ` (runs both ` coverage-map ` and ` run-coverage ` )
4
7
5
8
## Maintenance note
6
9
7
10
These tests can be sensitive to small changes in MIR spans or MIR control flow,
8
11
especially in HIR-to-MIR lowering or MIR optimizations.
9
12
10
- If you haven't touched the coverage code directly, and the ` run-coverage ` test
11
- suite still works , then it should usually be OK to just ` -- bless` these
12
- coverage mapping tests as necessary , without worrying too much about the exact
13
- changes.
13
+ If you haven't touched the coverage code directly, and the tests still pass in
14
+ ` run-coverage ` mode , then it should usually be OK to just re- bless the mappings
15
+ as necessary with ` ./x.py test coverage-map --bless ` , without worrying too much
16
+ about the exact changes.
You can’t perform that action at this time.
0 commit comments