Skip to content

Commit 6439f2d

Browse files
committed
Avoid extra error for type mismatches in patterns
When a type error has already occurred, don't call ty::subst, which may ICE due to the mismatch in the number of type params involved. I'm deeming this too small to review. Closes #3680
1 parent 35209cb commit 6439f2d

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/librustc/middle/typeck/check/alt.rs

+10-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,16 @@ fn check_pat_variant(pcx: pat_ctxt, pat: @ast::pat, path: @ast::path,
9595
let vinfo =
9696
ty::enum_variant_with_id(
9797
tcx, v_def_ids.enm, v_def_ids.var);
98-
vinfo.args.map(|t| { ty::subst(tcx, expected_substs, *t) })
98+
let var_tpt = ty::lookup_item_type(tcx, v_def_ids.var);
99+
vinfo.args.map(|t| {
100+
if var_tpt.bounds.len() == expected_substs.tps.len() {
101+
ty::subst(tcx, expected_substs, *t)
102+
}
103+
else {
104+
*t // In this case, an error was already signaled
105+
// anyway
106+
}
107+
})
99108
};
100109

101110
kind_name = "variant";

src/test/compile-fail/issue-3680.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
// xfail-test
12-
fn f() {
11+
fn main() {
1312
match None {
1413
Err(_) => () //~ ERROR expected `core::result
1514
}

0 commit comments

Comments
 (0)