Auto merge of #134626 - veera-sivarajan:five-codegen-tests, r=Mark-Si…

…mulacrum

Add Four Codegen Tests

Closes #74615
Closes #123216
Closes #49572
Closes #93514

This PR adds four codegen tests. The FileCheck assertions were generated with the help of `update_test_checks.py` and `update_llc_test_checks.py` from the LLVM project.

tests/assembly/indexing-with-bools-no-redundant-instructions.rs

@@ -0,0 +1,30 @@
+//@ assembly-output: emit-asm
+//@ only-x86_64
+//@ compile-flags: -O
+//! Ensure that indexing a slice with `bool` does not
+//! generate any redundant `jmp` and `and` instructions.
+//! Discovered in issue #123216.
+
+#![crate_type = "lib"]
+
+#[no_mangle]
+fn f(a: u32, b: bool, c: bool, d: &mut [u128; 2]) {
+    // CHECK-LABEL: f:
+    // CHECK: testl  %esi, %esi
+    // CHECK: je
+    // CHECK: xorb   %dl, %dil
+    // CHECK: orb    $1, (%rcx)
+    // CHECK: movzbl %dil, %eax
+    // CHECK: andl   $1, %eax
+    // CHECK: shll   $4, %eax
+    // CHECK: orb    $1, (%rcx,%rax)
+    // CHECK-NOT:     jmp
+    // CHECK-NOT:     andl %dil, $1
+    // CHECK: retq
+    let mut a = a & 1 != 0;
+    if b {
+        a ^= c;
+        d[0] |= 1;
+    }
+    d[a as usize] |= 1;
+}

tests/codegen/classify-fp-category-of-usize-without-branch.rs

@@ -0,0 +1,53 @@
+//@ compile-flags: -O
+//! Ensure that classifying `FpCategory` based on `usize` compiles to
+//! a handful of instructions without any `switch` or branches.
+//! This regressed between rustc 1.37 and 1.38 and was discovered
+//! in issue #74615.
+
+#![crate_type = "lib"]
+
+use std::num::FpCategory;
+
+fn conv(input: usize) -> FpCategory {
+    match input {
+        0b10000000 | 0b00000001 => FpCategory::Infinite,
+        0b01000000 | 0b00000010 => FpCategory::Normal,
+        0b00100000 | 0b00000100 => FpCategory::Subnormal,
+        0b00010000 | 0b00001000 => FpCategory::Zero,
+        0b100000000 | 0b1000000000 => FpCategory::Nan,
+        _ => unsafe { std::hint::unreachable_unchecked() },
+    }
+}
+
+#[no_mangle]
+pub fn complex_test(input: usize) -> bool {
+    // CHECK-LABEL: @complex_test(
+    // CHECK-SAME: i64 noundef [[INPUT:%.*]]) unnamed_addr #[[ATTR0:[0-9]+]] {
+    // CHECK:    [[TMP0:%.*]] = tail call
+    // CHECK:    [[DOTOFF:%.*]] = add nsw i64 [[TMP0]], -3
+    // CHECK:    [[SWITCH:%.*]] = icmp ult i64 [[DOTOFF]], 2
+    // CHECK-NOT:   switch i64
+    // CHECK-NOT:   br
+    // CHECK-NOT:   label
+    // CHECK:    ret i1 [[SWITCH]]
+    //
+    conv(input) == FpCategory::Zero
+}
+
+#[no_mangle]
+pub fn simpler_test(input: usize) -> bool {
+    // CHECK-LABEL: @simpler_test(
+    // CHECK-SAME: i64 noundef [[INPUT:%.*]]) unnamed_addr #[[ATTR0]] {
+    // CHECK:    [[TMP0:%.*]] = add i64 [[INPUT]], -8
+    // CHECK:    [[SWITCH_AND:%.*]] = and i64 [[TMP0]], -9
+    // CHECK:    [[SWITCH_SELECTCMP:%.*]] = icmp eq i64 [[SWITCH_AND]], 0
+    // CHECK-NOT:   switch i64
+    // CHECK-NOT:   br
+    // CHECK-NOT:   label
+    // CHECK:    ret i1 [[SWITCH_SELECTCMP]]
+    //
+    match input {
+        0b00010000 | 0b00001000 => true,
+        _ => false,
+    }
+}

tests/codegen/nonzero-type-not-zero-on-get.rs

@@ -0,0 +1,20 @@
+//@ compile-flags: -O
+//! Ensure that `.get()` on `std::num::NonZero*` types do not
+//! check for zero equivalency.
+//! Discovered in issue #49572.
+
+#![crate_type = "lib"]
+
+#[no_mangle]
+pub fn foo(x: std::num::NonZeroU32) -> bool {
+    // CHECK-LABEL: @foo(
+    // CHECK: ret i1 true
+    x.get() != 0
+}
+
+#[no_mangle]
+pub fn bar(x: std::num::NonZeroI64) -> bool {
+    // CHECK-LABEL: @bar(
+    // CHECK: ret i1 true
+    x.get() != 0
+}

tests/codegen/unreachable-branch-not-generated.rs

@@ -0,0 +1,41 @@
+//@ compile-flags: -O
+//! Ensure that matching on `x % 5` generates an unreachable
+//! branch for values greater than 4.
+//! Discovered in issue #93514.
+
+#![crate_type = "lib"]
+
+#[no_mangle]
+pub unsafe fn parse0(x: usize) -> usize {
+    // CHECK-LABEL: define noundef i64 @parse0(
+    // CHECK-SAME: i64 noundef [[X:%.*]]) unnamed_addr #[[ATTR0:[0-9]+]] {
+    // CHECK-NEXT:  [[START:.*:]]
+    // CHECK-NEXT:    [[_2:%.*]] = urem i64 [[X]], 5
+    // CHECK-NEXT:    switch i64 [[_2]], label %[[DEFAULT_UNREACHABLE1:.*]] [
+    // CHECK-NEXT:      i64 0, label %[[BB6:.*]]
+    // CHECK-NEXT:      i64 1, label %[[BB5:.*]]
+    // CHECK-NEXT:      i64 2, label %[[BB4:.*]]
+    // CHECK-NEXT:      i64 3, label %[[BB3:.*]]
+    // CHECK-NEXT:      i64 4, label %[[BB2:.*]]
+    // CHECK-NEXT:    ]
+    // CHECK:       [[DEFAULT_UNREACHABLE1]]:
+    // CHECK-NEXT:    unreachable
+    // CHECK:    ret i64
+    match x % 5 {
+        0 => f1(x),
+        1 => f2(x),
+        2 => f3(x),
+        3 => f4(x),
+        4 => f5(x),
+        _ => eliminate_me(),
+    }
+}
+
+extern "Rust" {
+    fn eliminate_me() -> usize;
+    fn f1(x: usize) -> usize;
+    fn f2(x: usize) -> usize;
+    fn f3(x: usize) -> usize;
+    fn f4(x: usize) -> usize;
+    fn f5(x: usize) -> usize;
+}