Skip to content

Commit 6765a77

Browse files
committed
(DO NOT MERGE) What happens to perf if we don't supply quoted args at all?
This demonstrates the theoretical limits of optimizing the quoting process.
1 parent 9f32ccf commit 6765a77

File tree

1 file changed

+10
-6
lines changed
  • compiler/rustc_codegen_llvm/src/back

1 file changed

+10
-6
lines changed

compiler/rustc_codegen_llvm/src/back/write.rs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -253,12 +253,16 @@ pub(crate) fn target_machine_factory(
253253
// Command-line information to be included in the target machine.
254254
// This seems to only be used for embedding in PDB debuginfo files.
255255
// FIXME(Zalathar): Maybe skip this for non-PDB targets?
256-
let argv0 = std::env::current_exe()
257-
.unwrap_or_default()
258-
.into_os_string()
259-
.into_string()
260-
.unwrap_or_default();
261-
let command_line_args = quote_command_line_args(&sess.expanded_args);
256+
if false {
257+
let _argv0 = std::env::current_exe()
258+
.unwrap_or_default()
259+
.into_os_string()
260+
.into_string()
261+
.unwrap_or_default();
262+
let _command_line_args = quote_command_line_args(&sess.expanded_args);
263+
}
264+
let argv0 = String::new();
265+
let command_line_args = String::new();
262266

263267
let debuginfo_compression = sess.opts.debuginfo_compression.to_string();
264268
match sess.opts.debuginfo_compression {

0 commit comments

Comments
 (0)