Skip to content

Commit 67fa90e

Browse files
committed
Print 'rustc' and 'rustdoc' as the command name for --version
Instead of just blindly printing arg[0], use a constant string. Partial fix for #13582
1 parent 2a7a391 commit 67fa90e

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/librustc/driver/mod.rs

+9-8
Original file line numberDiff line numberDiff line change
@@ -104,17 +104,17 @@ fn run_compiler(args: &[~str]) {
104104
driver::compile_input(sess, cfg, &input, &odir, &ofile);
105105
}
106106

107-
pub fn version(argv0: &str) {
107+
pub fn version(command: &str) {
108108
let vers = match option_env!("CFG_VERSION") {
109109
Some(vers) => vers,
110110
None => "unknown version"
111111
};
112-
println!("{} {}", argv0, vers);
112+
println!("{} {}", command, vers);
113113
println!("host: {}", driver::host_triple());
114114
}
115115

116-
fn usage(argv0: &str) {
117-
let message = format!("Usage: {} [OPTIONS] INPUT", argv0);
116+
fn usage() {
117+
let message = format!("Usage: rustc [OPTIONS] INPUT");
118118
println!("{}\n\
119119
Additional help:
120120
-C help Print codegen options
@@ -192,9 +192,10 @@ fn describe_codegen_flags() {
192192
/// should continue, returns a getopts::Matches object parsed from args, otherwise
193193
/// returns None.
194194
pub fn handle_options(mut args: Vec<~str>) -> Option<getopts::Matches> {
195-
let binary = args.shift().unwrap();
195+
// Throw away the first argument, the name of the binary
196+
let _binary = args.shift().unwrap();
196197

197-
if args.is_empty() { usage(binary); return None; }
198+
if args.is_empty() { usage(); return None; }
198199

199200
let matches =
200201
match getopts::getopts(args.as_slice(), config::optgroups().as_slice()) {
@@ -205,7 +206,7 @@ pub fn handle_options(mut args: Vec<~str>) -> Option<getopts::Matches> {
205206
};
206207

207208
if matches.opt_present("h") || matches.opt_present("help") {
208-
usage(binary);
209+
usage();
209210
return None;
210211
}
211212

@@ -234,7 +235,7 @@ pub fn handle_options(mut args: Vec<~str>) -> Option<getopts::Matches> {
234235
}
235236

236237
if matches.opt_present("v") || matches.opt_present("version") {
237-
version(binary);
238+
version("rustc");
238239
return None;
239240
}
240241

src/librustdoc/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ pub fn main_args(args: &[StrBuf]) -> int {
153153
usage(args[0].as_slice());
154154
return 0;
155155
} else if matches.opt_present("version") {
156-
rustc::driver::version(args[0].as_slice());
156+
rustc::driver::version("rustdoc");
157157
return 0;
158158
}
159159

0 commit comments

Comments
 (0)