Skip to content

Commit 6994651

Browse files
committed
fix debuginfo for windows_gnullvm_base.rs
These lines (including the FIXME comment) were added to windows_gnu_base.rs in cf2c492 but windows_gnullvm_base.rs was not updated. This resulted in an error `LLVM ERROR: dwo only supported with ELF and Wasm` attempting to build on aarch64-pc-windows-gnullvm. Signed-off-by: Jeremy Drake <github@jdrake.com>
1 parent 1e1e5b8 commit 6994651

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

compiler/rustc_target/src/spec/windows_gnullvm_base.rs

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
use crate::spec::{cvs, Cc, LinkerFlavor, Lld, TargetOptions};
1+
use crate::spec::{cvs, Cc, DebuginfoKind, LinkerFlavor, Lld, SplitDebuginfo, TargetOptions};
2+
use std::borrow::Cow;
23

34
pub fn opts() -> TargetOptions {
45
// We cannot use `-nodefaultlibs` because compiler-rt has to be passed
@@ -36,7 +37,10 @@ pub fn opts() -> TargetOptions {
3637
eh_frame_header: false,
3738
no_default_libraries: false,
3839
has_thread_local: true,
39-
40+
// FIXME(davidtwco): Support Split DWARF on Windows GNU - may require LLVM changes to
41+
// output DWO, despite using DWARF, doesn't use ELF..
42+
debuginfo_kind: DebuginfoKind::Pdb,
43+
supported_split_debuginfo: Cow::Borrowed(&[SplitDebuginfo::Off]),
4044
..Default::default()
4145
}
4246
}

0 commit comments

Comments
 (0)