Skip to content

Commit

Permalink
Rollup merge of #133013 - matthiaskrgr:crash_aux, r=onur-ozkan
Browse files Browse the repository at this point in the history
compiletest: known-bug / crashes: allow for an "auxiliary" directory to contain files that do not have a "known-bug" directive

Fixes #133009

r? `@jieyouxu`
  • Loading branch information
GuillaumeGomez authored Nov 14, 2024
2 parents e3c76c5 + 73c6494 commit 6a783a4
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions src/tools/tidy/src/known_bug.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,22 @@ use crate::walk::*;

pub fn check(filepath: &Path, bad: &mut bool) {
walk(filepath, |path, _is_dir| filter_not_rust(path), &mut |entry, contents| {
let file = entry.path();
if !contents.lines().any(|line| line.starts_with("//@ known-bug: ")) {
let file: &Path = entry.path();

// files in "auxiliary" do not need to crash by themselves
let test_path_segments =
file.iter().map(|s| s.to_string_lossy().into()).collect::<Vec<String>>();
let test_path_segments_str =
test_path_segments.iter().map(|s| s.as_str()).collect::<Vec<&str>>();

if !matches!(test_path_segments_str[..], [
..,
"tests",
"crashes",
"auxiliary",
_aux_file_rs
]) && !contents.lines().any(|line| line.starts_with("//@ known-bug: "))
{
tidy_error!(
bad,
"{} crash/ice test does not have a \"//@ known-bug: \" directive",
Expand Down

0 comments on commit 6a783a4

Please sign in to comment.