Skip to content

Commit 6d3d4b9

Browse files
committed
Merge pull request #3278 from erickt/incoming
A couple minor cleanups
2 parents d77acf7 + dab3339 commit 6d3d4b9

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/libstd/ebml.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ enum ebml_serializer_tag {
320320

321321
trait serializer_priv {
322322
fn _emit_tagged_uint(t: ebml_serializer_tag, v: uint);
323-
fn _emit_label(label: ~str);
323+
fn _emit_label(label: &str);
324324
}
325325

326326
impl ebml::writer: serializer_priv {
@@ -330,7 +330,7 @@ impl ebml::writer: serializer_priv {
330330
self.wr_tagged_u32(t as uint, v as u32);
331331
}
332332

333-
fn _emit_label(label: ~str) {
333+
fn _emit_label(label: &str) {
334334
// There are various strings that we have access to, such as
335335
// the name of a record field, which do not actually appear in
336336
// the serialized EBML (normally). This is just for
@@ -365,11 +365,11 @@ impl ebml::writer: serialization::serializer {
365365

366366
fn emit_str(v: &str) { self.wr_tagged_str(es_str as uint, v) }
367367

368-
fn emit_enum(name: ~str, f: fn()) {
368+
fn emit_enum(name: &str, f: fn()) {
369369
self._emit_label(name);
370370
self.wr_tag(es_enum as uint, f)
371371
}
372-
fn emit_enum_variant(_v_name: ~str, v_id: uint, _cnt: uint, f: fn()) {
372+
fn emit_enum_variant(_v_name: &str, v_id: uint, _cnt: uint, f: fn()) {
373373
self._emit_tagged_uint(es_enum_vid, v_id);
374374
self.wr_tag(es_enum_body as uint, f)
375375
}
@@ -389,7 +389,7 @@ impl ebml::writer: serialization::serializer {
389389
fn emit_box(f: fn()) { f() }
390390
fn emit_uniq(f: fn()) { f() }
391391
fn emit_rec(f: fn()) { f() }
392-
fn emit_rec_field(f_name: ~str, _f_idx: uint, f: fn()) {
392+
fn emit_rec_field(f_name: &str, _f_idx: uint, f: fn()) {
393393
self._emit_label(f_name);
394394
f()
395395
}

src/libstd/net_tcp.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ fn connect(-input_ip: ip::ip_addr, port: uint,
153153
0i32 => {
154154
log(debug, ~"tcp_init successful");
155155
match input_ip {
156-
ipv4 => {
156+
_ipv4 => {
157157
log(debug, ~"dealing w/ ipv4 connection..");
158158
let connect_req_ptr =
159159
ptr::addr_of((*socket_data_ptr).connect_req);

src/libstd/prettyprint.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ impl Writer: serializer {
6767
self.write_str(fmt!("%?", v));
6868
}
6969

70-
fn emit_enum(_name: ~str, f: fn()) {
70+
fn emit_enum(_name: &str, f: fn()) {
7171
f();
7272
}
7373

74-
fn emit_enum_variant(v_name: ~str, _v_id: uint, sz: uint, f: fn()) {
74+
fn emit_enum_variant(v_name: &str, _v_id: uint, sz: uint, f: fn()) {
7575
self.write_str(v_name);
7676
if sz > 0u { self.write_str(~"("); }
7777
f();
@@ -110,7 +110,7 @@ impl Writer: serializer {
110110
self.write_str(~"}");
111111
}
112112

113-
fn emit_rec_field(f_name: ~str, f_idx: uint, f: fn()) {
113+
fn emit_rec_field(f_name: &str, f_idx: uint, f: fn()) {
114114
if f_idx > 0u { self.write_str(~", "); }
115115
self.write_str(f_name);
116116
self.write_str(~": ");

src/libstd/serialization.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ trait serializer {
2626
fn emit_str(v: &str);
2727

2828
// Compound types:
29-
fn emit_enum(name: ~str, f: fn());
30-
fn emit_enum_variant(v_name: ~str, v_id: uint, sz: uint, f: fn());
29+
fn emit_enum(name: &str, f: fn());
30+
fn emit_enum_variant(v_name: &str, v_id: uint, sz: uint, f: fn());
3131
fn emit_enum_variant_arg(idx: uint, f: fn());
3232
fn emit_vec(len: uint, f: fn());
3333
fn emit_vec_elt(idx: uint, f: fn());
3434
fn emit_box(f: fn());
3535
fn emit_uniq(f: fn());
3636
fn emit_rec(f: fn());
37-
fn emit_rec_field(f_name: ~str, f_idx: uint, f: fn());
37+
fn emit_rec_field(f_name: &str, f_idx: uint, f: fn());
3838
fn emit_tup(sz: uint, f: fn());
3939
fn emit_tup_elt(idx: uint, f: fn());
4040
}

0 commit comments

Comments
 (0)