Skip to content

Commit 6f0e58f

Browse files
committed
Stop re-exporting MutateMode's variants.
1 parent dc1f442 commit 6f0e58f

File tree

4 files changed

+18
-14
lines changed

4 files changed

+18
-14
lines changed

src/librustc/middle/check_match.rs

+4-5
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ use middle::const_eval::{const_expr_to_pat, lookup_const_by_id};
1818
use middle::const_eval::EvalHint::ExprTypeChecked;
1919
use middle::def::*;
2020
use middle::def_id::{DefId};
21-
use middle::expr_use_visitor::{ConsumeMode, Delegate, ExprUseVisitor, Init};
22-
use middle::expr_use_visitor::{JustWrite, LoanCause, MutateMode};
23-
use middle::expr_use_visitor::WriteAndRead;
21+
use middle::expr_use_visitor::{ConsumeMode, Delegate, ExprUseVisitor};
22+
use middle::expr_use_visitor::{LoanCause, MutateMode};
2423
use middle::expr_use_visitor as euv;
2524
use middle::infer;
2625
use middle::mem_categorization::{cmt};
@@ -1160,10 +1159,10 @@ impl<'a, 'tcx> Delegate<'tcx> for MutationChecker<'a, 'tcx> {
11601159
fn decl_without_init(&mut self, _: NodeId, _: Span) {}
11611160
fn mutate(&mut self, _: NodeId, span: Span, _: cmt, mode: MutateMode) {
11621161
match mode {
1163-
JustWrite | WriteAndRead => {
1162+
MutateMode::JustWrite | MutateMode::WriteAndRead => {
11641163
span_err!(self.cx.tcx.sess, span, E0302, "cannot assign in a pattern guard")
11651164
}
1166-
Init => {}
1165+
MutateMode::Init => {}
11671166
}
11681167
}
11691168
}

src/librustc/middle/expr_use_visitor.rs

+8-5
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
//! normal visitor, which just walks the entire body in one shot, the
1313
//! `ExprUseVisitor` determines how expressions are being used.
1414
15-
pub use self::MutateMode::*;
1615
pub use self::LoanCause::*;
1716
pub use self::ConsumeMode::*;
1817
pub use self::MoveReason::*;
@@ -465,7 +464,11 @@ impl<'d,'t,'a,'tcx> ExprUseVisitor<'d,'t,'a,'tcx> {
465464
self.consume_expr(&*output.expr);
466465
} else {
467466
self.mutate_expr(expr, &*output.expr,
468-
if output.is_rw { WriteAndRead } else { JustWrite });
467+
if output.is_rw {
468+
MutateMode::WriteAndRead
469+
} else {
470+
MutateMode::JustWrite
471+
});
469472
}
470473
}
471474
}
@@ -519,7 +522,7 @@ impl<'d,'t,'a,'tcx> ExprUseVisitor<'d,'t,'a,'tcx> {
519522
}
520523

521524
hir::ExprAssign(ref lhs, ref rhs) => {
522-
self.mutate_expr(expr, &**lhs, JustWrite);
525+
self.mutate_expr(expr, &**lhs, MutateMode::JustWrite);
523526
self.consume_expr(&**rhs);
524527
}
525528

@@ -532,7 +535,7 @@ impl<'d,'t,'a,'tcx> ExprUseVisitor<'d,'t,'a,'tcx> {
532535
assert!(::rustc_front::util::is_by_value_binop(op.node));
533536

534537
if !self.walk_overloaded_operator(expr, lhs, vec![rhs], PassArgs::ByValue) {
535-
self.mutate_expr(expr, &**lhs, WriteAndRead);
538+
self.mutate_expr(expr, &**lhs, MutateMode::WriteAndRead);
536539
self.consume_expr(&**rhs);
537540
}
538541
}
@@ -991,7 +994,7 @@ impl<'d,'t,'a,'tcx> ExprUseVisitor<'d,'t,'a,'tcx> {
991994
let def = def_map.borrow().get(&pat.id).unwrap().full_def();
992995
match mc.cat_def(pat.id, pat.span, pat_ty, def) {
993996
Ok(binding_cmt) => {
994-
delegate.mutate(pat.id, pat.span, binding_cmt, Init);
997+
delegate.mutate(pat.id, pat.span, binding_cmt, MutateMode::Init);
995998
}
996999
Err(_) => { }
9971000
}

src/librustc_borrowck/borrowck/check_loans.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ use self::UseError::*;
2121
use borrowck::*;
2222
use borrowck::InteriorKind::{InteriorElement, InteriorField};
2323
use rustc::middle::expr_use_visitor as euv;
24+
use rustc::middle::expr_use_visitor::MutateMode;
2425
use rustc::middle::infer;
2526
use rustc::middle::mem_categorization as mc;
2627
use rustc::middle::mem_categorization::Categorization;
@@ -161,7 +162,7 @@ impl<'a, 'tcx> euv::Delegate<'tcx> for CheckLoanCtxt<'a, 'tcx> {
161162
match opt_loan_path(&assignee_cmt) {
162163
Some(lp) => {
163164
match mode {
164-
euv::Init | euv::JustWrite => {
165+
MutateMode::Init | MutateMode::JustWrite => {
165166
// In a case like `path = 1`, then path does not
166167
// have to be *FULLY* initialized, but we still
167168
// must be careful lest it contains derefs of
@@ -171,7 +172,7 @@ impl<'a, 'tcx> euv::Delegate<'tcx> for CheckLoanCtxt<'a, 'tcx> {
171172
MovedInUse,
172173
&lp);
173174
}
174-
euv::WriteAndRead => {
175+
MutateMode::WriteAndRead => {
175176
// In a case like `path += 1`, then path must be
176177
// fully initialized, since we will read it before
177178
// we write it.

src/librustc_borrowck/borrowck/move_data.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ use rustc::middle::dataflow::BitwiseOperator;
2020
use rustc::middle::dataflow::DataFlowOperator;
2121
use rustc::middle::dataflow::KillFrom;
2222
use rustc::middle::expr_use_visitor as euv;
23+
use rustc::middle::expr_use_visitor::MutateMode;
2324
use rustc::middle::ty;
2425
use rustc::util::nodemap::{FnvHashMap, NodeSet};
2526

@@ -406,10 +407,10 @@ impl<'tcx> MoveData<'tcx> {
406407
self.fragments.borrow_mut().add_assignment(path_index);
407408

408409
match mode {
409-
euv::Init | euv::JustWrite => {
410+
MutateMode::Init | MutateMode::JustWrite => {
410411
self.assignee_ids.borrow_mut().insert(assignee_id);
411412
}
412-
euv::WriteAndRead => { }
413+
MutateMode::WriteAndRead => { }
413414
}
414415

415416
let assignment = Assignment {

0 commit comments

Comments
 (0)