Skip to content

Commit

Permalink
run-make-support: remove env_var
Browse files Browse the repository at this point in the history
This is incorrectly named (it's actually `env_clear`), and is itself
a gigantic footgun: removing `TMPDIR` on Unix and `TMP`/`TEMP` on
Windows basically wrecks anything that relies on `std::env::temp_dir`
from functioning correctly. For example, this includes rustc's codegen.
  • Loading branch information
jieyouxu committed Jun 11, 2024
1 parent aec67e2 commit 7255c28
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/tools/run-make-support/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -364,12 +364,6 @@ macro_rules! impl_common_helpers {
self
}

/// Clear all environmental variables.
pub fn env_var(&mut self) -> &mut Self {
self.cmd.env_clear();
self
}

/// Generic command argument provider. Prefer specific helper methods if possible.
/// Note that for some executables, arguments might be platform specific. For C/C++
/// compilers, arguments might be platform *and* compiler specific.
Expand Down

0 comments on commit 7255c28

Please sign in to comment.