Skip to content

Commit 78e7d9b

Browse files
committed
Re-enable debuginfo tests that have been ignored
Most of these tests either ran perfectly once enabled or only needed a small amount of tweaking to get passing or used ignore-test when ignore-lldb would have been more appropriate. With this change we go from 64 ignored tests to 50.
1 parent f0c4da4 commit 78e7d9b

12 files changed

+3
-16
lines changed

src/test/debuginfo/basic-types-globals-metadata.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// min-lldb-version: 310
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32

43
// compile-flags:-g
54
// gdb-command:run
@@ -11,7 +10,7 @@
1110
// gdb-check:type = isize
1211
// gdbg-command:whatis 'basic_types_globals_metadata::C'
1312
// gdbr-command:whatis basic_types_globals_metadata::C
14-
// gdb-check:type = char
13+
// gdb-check:type = char32_t
1514
// gdbg-command:whatis 'basic_types_globals_metadata::I8'
1615
// gdbr-command:whatis basic_types_globals_metadata::I8
1716
// gdb-check:type = i8

src/test/debuginfo/c-style-enum.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// ignore-aarch64
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32
// min-lldb-version: 310
43

54
// compile-flags:-g

src/test/debuginfo/cross-crate-spans.rs

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
// This fails on lldb 6.0.1 on x86-64 Fedora 28; so mark it macOS-only
77
// for now.
8-
// only-macos
98

109
// aux-build:cross_crate_spans.rs
1110
extern crate cross_crate_spans;

src/test/debuginfo/destructured-for-loop-variable.rs

-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
// min-lldb-version: 310
22

3-
// This fails on lldb 6.0.1 on x86-64 Fedora 28; so mark it macOS-only
4-
// for now.
5-
// only-macos
6-
73
// compile-flags:-g
84

95
// === GDB TESTS ===================================================================================

src/test/debuginfo/function-arg-initialization.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
1+
// ignore-lldb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
22
// min-lldb-version: 310
33

44
// This test case checks if function arguments already have the correct value

src/test/debuginfo/lexical-scopes-in-block-expression.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// min-lldb-version: 310
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32

43
// compile-flags:-g
54

src/test/debuginfo/limited-debuginfo.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// ignore-lldb
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32

43
// compile-flags:-C debuginfo=1
54

src/test/debuginfo/method-on-enum.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// min-lldb-version: 310
2-
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
2+
// ignore-lldb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
33

44
// compile-flags:-g
55

src/test/debuginfo/simple-struct.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// min-lldb-version: 310
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32

43
// compile-flags:-g
54

src/test/debuginfo/simple-tuple.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// min-lldb-version: 310
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32

43
// compile-flags:-g
54

src/test/debuginfo/union-smoke.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// min-lldb-version: 310
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32

43
// ignore-gdb-version: 7.11.90 - 7.12.9
54

src/test/debuginfo/vec.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// min-lldb-version: 310
2-
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
32

43
// compile-flags:-g
54

0 commit comments

Comments
 (0)