Skip to content

Commit 79b6bad

Browse files
borsbors
committed
Auto merge of #97086 - 5225225:link-section-is-unsafe, r=davidtwco
Report unsafe for overriding link sections I'm not too sure about the lint wording here, but I couldn't think of anything better.
2 parents e70c60d + a42a7a3 commit 79b6bad

File tree

3 files changed

+64
-16
lines changed

3 files changed

+64
-16
lines changed

‎compiler/rustc_lint/src/builtin.rs

+29
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,17 @@ impl UnsafeCode {
338338
.emit();
339339
})
340340
}
341+
342+
fn report_overridden_symbol_section(&self, cx: &EarlyContext<'_>, span: Span, msg: &str) {
343+
self.report_unsafe(cx, span, |lint| {
344+
lint.build(msg)
345+
.note(
346+
"the program's behavior with overridden link sections on items is unpredictable \
347+
and Rust cannot provide guarantees when you manually override them",
348+
)
349+
.emit();
350+
})
351+
}
341352
}
342353

343354
impl EarlyLintPass for UnsafeCode {
@@ -385,13 +396,22 @@ impl EarlyLintPass for UnsafeCode {
385396
"declaration of a `no_mangle` function",
386397
);
387398
}
399+
388400
if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::export_name) {
389401
self.report_overridden_symbol_name(
390402
cx,
391403
attr.span,
392404
"declaration of a function with `export_name`",
393405
);
394406
}
407+
408+
if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::link_section) {
409+
self.report_overridden_symbol_section(
410+
cx,
411+
attr.span,
412+
"declaration of a function with `link_section`",
413+
);
414+
}
395415
}
396416

397417
ast::ItemKind::Static(..) => {
@@ -402,13 +422,22 @@ impl EarlyLintPass for UnsafeCode {
402422
"declaration of a `no_mangle` static",
403423
);
404424
}
425+
405426
if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::export_name) {
406427
self.report_overridden_symbol_name(
407428
cx,
408429
attr.span,
409430
"declaration of a static with `export_name`",
410431
);
411432
}
433+
434+
if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::link_section) {
435+
self.report_overridden_symbol_section(
436+
cx,
437+
attr.span,
438+
"declaration of a static with `link_section`",
439+
);
440+
}
412441
}
413442

414443
_ => {}

‎src/test/ui/lint/lint-unsafe-code.rs

+3
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ impl AssocFnTrait for AssocFnFoo {
4848
#[export_name = "bar"] fn bar() {} //~ ERROR: declaration of a function with `export_name`
4949
#[export_name = "BAR"] static BAR: u32 = 5; //~ ERROR: declaration of a static with `export_name`
5050

51+
#[link_section = ".example_section"] fn uwu() {} //~ ERROR: declaration of a function with `link_section`
52+
#[link_section = ".example_section"] static UWU: u32 = 5; //~ ERROR: declaration of a static with `link_section`
53+
5154
struct AssocFnBar;
5255

5356
impl AssocFnBar {

‎src/test/ui/lint/lint-unsafe-code.stderr

+32-16
Original file line numberDiff line numberDiff line change
@@ -51,96 +51,112 @@ LL | #[export_name = "BAR"] static BAR: u32 = 5;
5151
|
5252
= note: the linker's behavior with multiple libraries exporting duplicate symbol names is undefined and Rust cannot provide guarantees when you manually override them
5353

54+
error: declaration of a function with `link_section`
55+
--> $DIR/lint-unsafe-code.rs:51:1
56+
|
57+
LL | #[link_section = ".example_section"] fn uwu() {}
58+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
59+
|
60+
= note: the program's behavior with overridden link sections on items is unpredictable and Rust cannot provide guarantees when you manually override them
61+
62+
error: declaration of a static with `link_section`
63+
--> $DIR/lint-unsafe-code.rs:52:1
64+
|
65+
LL | #[link_section = ".example_section"] static UWU: u32 = 5;
66+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
67+
|
68+
= note: the program's behavior with overridden link sections on items is unpredictable and Rust cannot provide guarantees when you manually override them
69+
5470
error: declaration of a method with `export_name`
55-
--> $DIR/lint-unsafe-code.rs:54:5
71+
--> $DIR/lint-unsafe-code.rs:57:5
5672
|
5773
LL | #[export_name = "bar"] fn bar() {}
5874
| ^^^^^^^^^^^^^^^^^^^^^^
5975
|
6076
= note: the linker's behavior with multiple libraries exporting duplicate symbol names is undefined and Rust cannot provide guarantees when you manually override them
6177

6278
error: declaration of a method with `export_name`
63-
--> $DIR/lint-unsafe-code.rs:58:5
79+
--> $DIR/lint-unsafe-code.rs:61:5
6480
|
6581
LL | #[export_name = "bar"] fn foo() {}
6682
| ^^^^^^^^^^^^^^^^^^^^^^
6783
|
6884
= note: the linker's behavior with multiple libraries exporting duplicate symbol names is undefined and Rust cannot provide guarantees when you manually override them
6985

7086
error: declaration of an `unsafe` function
71-
--> $DIR/lint-unsafe-code.rs:61:1
87+
--> $DIR/lint-unsafe-code.rs:64:1
7288
|
7389
LL | unsafe fn baz() {}
7490
| ^^^^^^^^^^^^^^^^^^
7591

7692
error: declaration of an `unsafe` trait
77-
--> $DIR/lint-unsafe-code.rs:62:1
93+
--> $DIR/lint-unsafe-code.rs:65:1
7894
|
7995
LL | unsafe trait Foo {}
8096
| ^^^^^^^^^^^^^^^^^^^
8197

8298
error: implementation of an `unsafe` trait
83-
--> $DIR/lint-unsafe-code.rs:63:1
99+
--> $DIR/lint-unsafe-code.rs:66:1
84100
|
85101
LL | unsafe impl Foo for Bar {}
86102
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
87103

88104
error: declaration of an `unsafe` method
89-
--> $DIR/lint-unsafe-code.rs:66:5
105+
--> $DIR/lint-unsafe-code.rs:69:5
90106
|
91107
LL | unsafe fn baz(&self);
92108
| ^^^^^^^^^^^^^^^^^^^^^
93109

94110
error: implementation of an `unsafe` method
95-
--> $DIR/lint-unsafe-code.rs:67:5
111+
--> $DIR/lint-unsafe-code.rs:70:5
96112
|
97113
LL | unsafe fn provided(&self) {}
98114
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
99115

100116
error: implementation of an `unsafe` method
101-
--> $DIR/lint-unsafe-code.rs:68:5
117+
--> $DIR/lint-unsafe-code.rs:71:5
102118
|
103119
LL | unsafe fn provided_override(&self) {}
104120
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
105121

106122
error: implementation of an `unsafe` method
107-
--> $DIR/lint-unsafe-code.rs:72:5
123+
--> $DIR/lint-unsafe-code.rs:75:5
108124
|
109125
LL | unsafe fn baz(&self) {}
110126
| ^^^^^^^^^^^^^^^^^^^^^^^
111127

112128
error: implementation of an `unsafe` method
113-
--> $DIR/lint-unsafe-code.rs:73:5
129+
--> $DIR/lint-unsafe-code.rs:76:5
114130
|
115131
LL | unsafe fn provided_override(&self) {}
116132
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
117133

118134
error: implementation of an `unsafe` method
119-
--> $DIR/lint-unsafe-code.rs:92:5
135+
--> $DIR/lint-unsafe-code.rs:95:5
120136
|
121137
LL | unsafe fn provided_override(&self) {}
122138
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
123139

124140
error: implementation of an `unsafe` method
125-
--> $DIR/lint-unsafe-code.rs:103:5
141+
--> $DIR/lint-unsafe-code.rs:106:5
126142
|
127143
LL | unsafe fn provided(&self) {}
128144
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
129145

130146
error: implementation of an `unsafe` method
131-
--> $DIR/lint-unsafe-code.rs:109:5
147+
--> $DIR/lint-unsafe-code.rs:112:5
132148
|
133149
LL | unsafe fn provided(&self) {}
134150
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
135151

136152
error: implementation of an `unsafe` method
137-
--> $DIR/lint-unsafe-code.rs:113:5
153+
--> $DIR/lint-unsafe-code.rs:116:5
138154
|
139155
LL | unsafe fn baz(&self) {}
140156
| ^^^^^^^^^^^^^^^^^^^^^^^
141157

142158
error: usage of an `unsafe` block
143-
--> $DIR/lint-unsafe-code.rs:124:5
159+
--> $DIR/lint-unsafe-code.rs:127:5
144160
|
145161
LL | unsafe {}
146162
| ^^^^^^^^^
@@ -204,5 +220,5 @@ LL | unsafe_in_macro!()
204220
|
205221
= note: this error originates in the macro `unsafe_in_macro` (in Nightly builds, run with -Z macro-backtrace for more info)
206222

207-
error: aborting due to 26 previous errors
223+
error: aborting due to 28 previous errors
208224

0 commit comments

Comments
 (0)