DO NOT SUBMIT: Switch to deny-by-default for crater

ia0 · ia0 · commit 7f8abab03b71 · 2019-06-29T13:09:40.000+02:00
diff --git a/src/librustc/lint/builtin.rs b/src/librustc/lint/builtin.rs
@@ -356,7 +356,7 @@ pub mod parser {
 
     declare_lint! {
         pub META_VARIABLE_MISUSE,
-        Allow,
+        Deny,
         "possible meta-variable misuse at macro definition"
     }
 }
diff --git a/src/test/ui/issues/issue-6596-1.rs b/src/test/ui/issues/issue-6596-1.rs
@@ -1,6 +1,6 @@
 macro_rules! e {
     ($inp:ident) => (
-        $nonexistent
+        $nonexistent //~ ERROR unknown macro variable `nonexistent`
         //~^ ERROR unknown macro variable `nonexistent`
     );
 }
diff --git a/src/test/ui/issues/issue-6596-1.stderr b/src/test/ui/issues/issue-6596-1.stderr
@@ -7,5 +7,13 @@ LL |         $nonexistent
 LL |     e!(foo);
    |     -------- in this macro invocation
 
-error: aborting due to previous error
+error: unknown macro variable `nonexistent`
+  --> $DIR/issue-6596-1.rs:3:9
+   |
+LL |         $nonexistent
+   |         ^^^^^^^^^^^^
+   |
+   = note: #[deny(meta_variable_misuse)] on by default
+
+error: aborting due to 2 previous errors
 
diff --git a/src/test/ui/issues/issue-6596-2.rs b/src/test/ui/issues/issue-6596-2.rs
@@ -2,7 +2,7 @@
 
 macro_rules! g {
     ($inp:ident) => (
-        { $inp $nonexistent }
+        { $inp $nonexistent } //~ ERROR unknown macro variable `nonexistent`
         //~^ ERROR unknown macro variable `nonexistent`
     );
 }
diff --git a/src/test/ui/issues/issue-6596-2.stderr b/src/test/ui/issues/issue-6596-2.stderr
@@ -7,5 +7,13 @@ LL |         { $inp $nonexistent }
 LL |     g!(foo);
    |     -------- in this macro invocation
 
-error: aborting due to previous error
+error: unknown macro variable `nonexistent`
+  --> $DIR/issue-6596-2.rs:5:16
+   |
+LL |         { $inp $nonexistent }
+   |                ^^^^^^^^^^^^
+   |
+   = note: #[deny(meta_variable_misuse)] on by default
+
+error: aborting due to 2 previous errors
 

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,7 @@ pub mod parser {`
`356`	`356`
`357`	`357`	`declare_lint! {`
`358`	`358`	`pub META_VARIABLE_MISUSE,`
`359`		`- Allow,`
	`359`	`+ Deny,`
`360`	`360`	`"possible meta-variable misuse at macro definition"`
`361`	`361`	`}`
`362`	`362`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`macro_rules! e {`
`2`	`2`	`($inp:ident) => (`
`3`		`- $nonexistent`
	`3`	+ $nonexistent //~ ERROR unknown macro variable `nonexistent`
`4`	`4`	//~^ ERROR unknown macro variable `nonexistent`
`5`	`5`	`);`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`macro_rules! g {`
`4`	`4`	`($inp:ident) => (`
`5`		`- { $inp $nonexistent }`
	`5`	+ { $inp $nonexistent } //~ ERROR unknown macro variable `nonexistent`
`6`	`6`	//~^ ERROR unknown macro variable `nonexistent`
`7`	`7`	`);`
`8`	`8`	`}`